Repository navigation
test(cache): run the remote cache e2e tests on Windows - #841
Merged
wan9chi merged 2 commits intoOct 12, 2026
Merged
Conversation
They were skipped on Windows because the e2e harness couldn't launch `remote-cache-server`, a pnpm command shim. The harness now resolves `.cmd` shims and starts them outside the verbatim temp path. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
wan9chi
added this pull request to stack #842
October 12, 2026 07:06
fspy benchmarklinuxmacoswindows |
On Windows, Node's `spawn` can't run pnpm's `.cmd` shims, so `remote-cache-server cbor-http ...` failed with `spawn cbor-http ENOENT`. cross-spawn runs them with the arguments escaped for `cmd.exe`. `pending_uploads` and `hide_pending_uploads` stay skipped on Windows for another reason: a milestone there is the console title, which ConPTY sends only as the latest title when it next renders, so `uploads-pending` can be replaced by the proxy's `stalled` milestone or not sent at all. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This was referenced Oct 12, 2026
wan9chi
added a commit
that referenced
this pull request
Oct 12, 2026
…#844) ## Motivation `remote_cache::ctrl_c_during_upload` passed on #841 but timed out on main in [`Test (windows-ignored)`](https://github.com/voidzero-dev/vite-task/actions/runs/38217517719/job/114706317248), waiting for the `uploads-pending` milestone. On Windows a milestone is the console title, and ConPTY sends only the latest title when it next renders. `vtt stalled-remote-cache` emits a `stalled` milestone when the upload arrives, which can be just after `vt run` emits `uploads-pending`. `stalled` then replaces it, and the harness waits until the test times out. `fast_fail_during_upload` has the same race, and it's why `pending_uploads` and `hide_pending_uploads` timed out on Windows in #841's first CI run. Only `ctrl_c_during_fetch` waits for `stalled`. ## Changes - `vtt stalled-remote-cache` emits the `stalled` milestone only with the new `--milestone` flag, which `ctrl_c_during_fetch` passes. - `pending_uploads` and `hide_pending_uploads` run on Windows again. #841 skipped `hide_pending_uploads` because nothing is printed after `uploads-pending`, but ConPTY sends a title change without other output, as `milestone_raw_mode_keystrokes` and `vtt exit-on-ctrlc` show. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The
remote_cacheandremote_cache_backende2e tests were skipped on Windows because the e2e harness couldn't launchremote-cache-server, a pnpm command shim invite-task-tools. #839 makes the harness resolve.cmdshims the wayvpdoes and start them outside the verbatim temp path, so these tests can run on Windows too.Changes
cfg = "not(windows)"from theremote_cacheandremote_cache_backendcases, along with the comments that explained the skip.remote-cache-serverstarts its command withcross-spawninstead of Node'sspawn, which can't run pnpm's.cmdshims on Windows (spawn cbor-http ENOENT).cross-spawnand@types/cross-spawnare added tovite-task-toolsthrough the catalog.pending_uploadsandhide_pending_uploadsstay skipped on Windows, now for a different, documented reason. A milestone there is the console title, and ConPTY sends only the latest title when it next renders. Inpending_uploads, the proxy'sstalledmilestone for the second upload can replaceuploads-pending. Inhide_pending_uploads, nothing is printed after it.🤖 Generated with Claude Code