Repository navigation
test(cache): emit the stalled milestone only when a test waits for it - #844
Merged
Merged
Conversation
On Windows a milestone is the console title, and ConPTY sends only the latest title when it next renders. The `stalled` milestone from `vtt stalled-remote-cache` could replace `uploads-pending`, so the cases that wait for it timed out. The proxy now emits `stalled` only with `--milestone`, which only ctrl_c_during_fetch uses, and pending_uploads and hide_pending_uploads run on Windows again. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
fspy benchmarklinuxmacoswindows |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
remote_cache::ctrl_c_during_uploadpassed on #841 but timed out on main inTest (windows-ignored), waiting for theuploads-pendingmilestone.On Windows a milestone is the console title, and ConPTY sends only the latest title when it next renders.
vtt stalled-remote-cacheemits astalledmilestone when the upload arrives, which can be just aftervt runemitsuploads-pending.stalledthen replaces it, and the harness waits until the test times out.fast_fail_during_uploadhas the same race, and it's whypending_uploadsandhide_pending_uploadstimed out on Windows in #841's first CI run. Onlyctrl_c_during_fetchwaits forstalled.Changes
vtt stalled-remote-cacheemits thestalledmilestone only with the new--milestoneflag, whichctrl_c_during_fetchpasses.pending_uploadsandhide_pending_uploadsrun on Windows again. test(cache): run the remote cache e2e tests on Windows #841 skippedhide_pending_uploadsbecause nothing is printed afteruploads-pending, but ConPTY sends a title change without other output, asmilestone_raw_mode_keystrokesandvtt exit-on-ctrlcshow.🤖 Generated with Claude Code