Repository navigation
Conversation
ConPTY emits only the latest console title when it renders, so a milestone could be replaced by another process's milestone before then. On Windows, `mark_milestone` now holds a lock shared by the processes in the test terminal from setting its title until the harness, having read the title, signals an event named after the milestone's id. `TestTerminal::spawn` names the lock through `VT_PTY_TERMINAL_TEST_MILESTONE_LOCK`. This lets `pending_uploads` and `hide_pending_uploads` run on Windows. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
fspy benchmarklinuxmacoswindows |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
On Windows a milestone is the console title, and ConPTY emits only the latest title when it renders. Another process's milestone could replace a milestone before that render. In
pending_uploadsandhide_pending_uploads, the proxy'sstalledmilestone can replaceuploads-pending. Both cases timed out waiting for it in Windows CI, so #841 skipped them on Windows.A side channel alone can't replace the title. The harness must also know that the screen includes everything printed before the milestone, and ConPTY guarantees that only for its rendered output (see #516). So the title stays, but each producer waits until the harness has seen its title.
Changes
mark_milestonetakes a named lock shared by the processes in the test terminal, sets its title, and holds the lock until the harness signals an event named after the milestone's random id.TestTerminal::spawnpasses the lock's name inVT_PTY_TERMINAL_TEST_MILESTONE_LOCK. A process that doesn't inherit this variable, such as a task thatvpruns with a filtered environment, only sets the title, as before.Readersignals the event for each milestone it reads, in bothexpect_milestoneandwait_for_exit.decode_milestone_titlereturns the id along with the name.vt_pty_terminal_testtests: two processes marking milestones at once, and a milestone with nothing printed after it.pending_uploadsandhide_pending_uploadsrun on Windows again.🤖 Generated with Claude Code