[masarray]

Source and safety

• Stacked on latest PR fix(SV/PTP): fast real AUTO synchronization to own PTP GM without 10-epoch delay #284 SOURCE_FAST full chain: exact baseline 1846fd003c97bbf58e482efe11bd2a4a69a0eac7; not main.
• 4I4V binary publisher preserves SCL sampling basis: SmpPerPeriod -> smpMod=0 and e.g. smpRate=80 for 4kHz@50Hz / 4.8kHz@60Hz; SmpPerSec -> smpMod=1 and rate 4000 or 4800. Validate actual frame-rate ratio 50/60 before admitting binary SCL mode.
• Legacy 9-2LE SCL optional omission remains valid and default include_sample_rate=false remains unchanged; ASCII PROFILE SV uses established samples/second mode and resets any stale SCL wire mode.
• STOP/START, PTP FSM and shared EMAC/GPTimer cadence not modified. Binary layout 4I4V descriptor and transactional BINCOMMIT remain fail-closed.
• Studio inspector displays exact decoded SCL-selected wire smpRate/smpMod, explicitly shows absent optional fields.
• Portable regression added for binary profile 50/60Hz, per-period wire BER and contradictory declared cadence rejection.

Gates

• Exact-SHA compiler/ESP32 IDF, C++ native tests and Windows native preview required before calling CI DONE. PCAP physical, actual SIPROTEC acceptance and failover remain pending. Keep DRAFT and do not merge main.

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-22T08:02:30.886315Z	88575b8	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 17a4fec776

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

Map SecPerSample to smpMod 2

When an opened SCL uses the supported SecPerSample/SecPerSmp sampling basis with SmvOpts@sampleRate=true, the compiler produces SvSampleMode::seconds_per_sample, but this ternary falls through to -1. The new inspector therefore reports smpMod -1 instead of the corresponding wire value 2; handle the third known mode explicitly and reserve the fallback for genuinely unknown values.

AGENTS.md reference: AGENTS.md:L300-L301

Useful? React with 👍 / 👎.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 88575b874f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

Repair the malformed preview workflow

In the windows-preview job, the run: | block ends prematurely at the dedented uses: line, leaving the SHA regex unterminated and line 403 as an invalid top-level YAML key. A YAML parse reports could not find expected ':', so GitHub cannot load this workflow and none of its firmware or Windows preview jobs can run; keep the complete SHA check inside the PowerShell block and remove the misplaced duplicate artifact step.

Useful? React with 👍 / 👎.

[masarray]

Disposition (2026-10-23): SUPERSEDED BY canonical Draft PR #286, NOT MERGED INTO main.

• Source head 88575b874f35827afa54c86f294e11a798f6b8ae is an exact ancestor of integration(RC · DO NOT MERGE): ARStack Studio + ESP32-P4 PTP/SV consolidated #286 head 8c58e73809e8460b1a7e2e84187a14eae594a7d0: GitHub compare is ahead, 0 behind. The SCL-preserved Ed2.1 4I4V smpRate/smpMod source and regression changes are preserved in canonical integration history; no separate cherry-pick or source-branch deletion.
• Following user physical feedback on 2026-10-23, local PTP/SV synchronization is reported to complete in ≤10 seconds. Earlier independent capture demonstrated smpSynch 0→2 at approximately 4.25 seconds on a different earlier firmware. This does not by itself prove receiver PTP LOCKED, full relay interop, or long soak.
• Still open in integration(RC · DO NOT MERGE): ARStack Studio + ESP32-P4 PTP/SV consolidated #286 acceptance: SIPROTEC physical 4I4V acceptance, 4800 fps/60 Hz physical matrix where required, and any exact-head full CI not executed for Draft. These are NOT being declared completed by closing this redundant source PR.
• Closure is housekeeping of an ancestry-contained, superseded branch. PR integration(RC · DO NOT MERGE): ARStack Studio + ESP32-P4 PTP/SV consolidated #286 remains Draft/unmerged; leave this branch intact for provenance.