Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8db8a70fa6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| CONFIG_AR_PTP_VLAN=y | ||
| CONFIG_AR_PTP_VLAN_ID=0 | ||
| CONFIG_AR_PTP_VLAN_PRIORITY=4 |
There was a problem hiding this comment.
When operators use this production firmware, it now emits PCP 4/VID 0 tagged PTP, but the published defaults still state that PTP is untagged in docs/PTP_LAB_TIMING.md:123-142 and docs/SMV_STUDIO_V0.1.1_PTP_PRODUCTION.md:9-18. This can lead bench configurations and capture expectations to omit the required priority tag, so the documented production defaults should be updated with this configuration change.
Useful? React with 👍 / 👎.
Root cause from 2026-10-21 capture
Existing SV wire frames were priority-tagged VID=0 PCP=4, but PTP Announce/Sync/Follow_Up were untagged. The PTP runtime and Studio actively rejected valid VLAN ID zero, preventing the standard IEEE 802.1Q priority-tagged Power Profile representation.
Changes
Safeguards
No spoofed GNSS traceability/clockClass, no unconditional smpSynch promotion; actual SV/PTP phase and MAC gating unchanged. External PTP RECEIVER configuration remains selectable. No change to SV payload / setpoints / serial owner or PTP STOP.
Next evidence required
PTP power profile checks in CI, matched firmware artifact, then isolated bench connected to the actual relay with peer-delay request-response capture, relay time-sync lock and SV subscription status. Neither VLAN tagging nor sender-side PCAP alone proves relay acceptance. Do not merge or publish stable release before physical qualification.
2026-10-23 PR hygiene disposition — SUPERSEDED, NO MERGE. Exact branch HEAD
ec54321c4b7022e4df784725166fce720e590522was checked with GitHub compare and is an ancestor of integration #286 at0e6c860f61a8780d09064369de5d29eb8c1b88c5(behind_by=0). Closed as a historical stacked checkpoint; its commits remain in the integration lineage and its branch is not deleted. This closure does NOT assert hardware acceptance or authorize merging #286. Divergent branches (especially #284's exclusive AUTO_FAILOVER commits), physical test candidate #285, and feature-unique PRs remain open for separate review.