Repository navigation
feat(SV P0): SCL-preserved IEC Ed2.1 4I4V smpRate/smpMod wire profiles #285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
3994f78
17a4fec
3ca1ff9
fa80cef
88575b8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -518,6 +518,15 @@ QVariantMap SclProfileModel::profileToVariantMap(const SvPublisherProfile& p) co | |
| map.insert(QStringLiteral("channelLeafCount"), static_cast<qulonglong>(p.channels.size())); | ||
| map.insert(QStringLiteral("includeDataSet"), p.asdu_options.data_set); | ||
| map.insert(QStringLiteral("includeSampleRate"), p.asdu_options.sample_rate); | ||
| map.insert(QStringLiteral("wireSmpRate"), | ||
| p.asdu_options.sample_rate | ||
| ? QVariant::fromValue(static_cast<qulonglong>(p.timing.configured_sample_rate)) | ||
| : QVariant{}); | ||
| map.insert(QStringLiteral("wireSmpMod"), | ||
| p.asdu_options.sample_rate | ||
| ? QVariant::fromValue(p.timing.sampling_basis == SvSampleMode::samples_per_period | ||
| ? 0 : p.timing.sampling_basis == SvSampleMode::samples_per_second ? 1 : -1) | ||
|
Comment on lines
+527
to
+528
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. When an opened SCL uses the supported AGENTS.md reference: AGENTS.md:L300-L301 Useful? React with 👍 / 👎. |
||
| : QVariant{}); | ||
| map.insert(QStringLiteral("sampleSynchronizedField"), p.asdu_options.sample_synchronized); | ||
|
|
||
| map.insert(QStringLiteral("iec61869Present"), p.iec61869_9.has_value()); | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the
windows-previewjob, therun: |block ends prematurely at the dedenteduses:line, leaving the SHA regex unterminated and line 403 as an invalid top-level YAML key. A YAML parse reportscould not find expected ':', so GitHub cannot load this workflow and none of its firmware or Windows preview jobs can run; keep the complete SHA check inside the PowerShell block and remove the misplaced duplicate artifact step.Useful? React with 👍 / 👎.