Repository navigation
Add typed JSON output to theme metafields pull - #8682
Merged
gonzaloriestra merged 7 commits intoOct 15, 2026
Merged
gonzaloriestra merged 7 commits into
gonzaloriestra merged 7 commits into
Conversation
This was referenced Sep 28, 2026
gonzaloriestra
added this pull request to stack #8673
September 28, 2026 09:53
This was referenced Sep 28, 2026
gonzaloriestra
marked this pull request as ready for review
September 28, 2026 10:22
gonzaloriestra
force-pushed
the
gonzalo/json-theme-metafields-pull
branch
from
September 28, 2026 10:25
e49d75e to
b3c2a68
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-init
branch
2 times, most recently
from
September 28, 2026 11:39
15928b5 to
af38492
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-metafields-pull
branch
from
September 28, 2026 11:39
b3c2a68 to
3907b2d
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-init
branch
from
September 28, 2026 11:52
af38492 to
9c90616
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-metafields-pull
branch
from
September 28, 2026 11:52
3907b2d to
6063572
Compare
isaacroldan
reviewed
Sep 29, 2026
gonzaloriestra
force-pushed
the
gonzalo/json-theme-metafields-pull
branch
from
September 29, 2026 10:28
6063572 to
cedfc3d
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-init
branch
from
October 9, 2026 13:09
f8c3844 to
e4f59f1
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-metafields-pull
branch
2 times, most recently
from
October 9, 2026 13:19
e601ab5 to
f477150
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-init
branch
2 times, most recently
from
October 9, 2026 14:01
ea75f3b to
e2f278b
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-metafields-pull
branch
from
October 9, 2026 14:01
f477150 to
07e0fab
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-init
branch
from
October 9, 2026 14:11
e2f278b to
4eb172b
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-metafields-pull
branch
from
October 9, 2026 14:11
07e0fab to
4a636ee
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-init
branch
from
October 14, 2026 08:08
4eb172b to
9ea220e
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-metafields-pull
branch
from
October 14, 2026 08:08
4a636ee to
6b45207
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-init
branch
from
October 15, 2026 09:56
9ea220e to
7912613
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-metafields-pull
branch
3 times, most recently
from
October 15, 2026 10:42
776aea4 to
4d2f628
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-init
branch
from
October 15, 2026 10:42
3ab13fb to
4537903
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-metafields-pull
branch
from
October 15, 2026 11:05
4d2f628 to
d88c624
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-init
branch
2 times, most recently
from
October 15, 2026 11:34
975035e to
757230e
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-metafields-pull
branch
from
October 15, 2026 11:34
d88c624 to
5820c38
Compare
3 of 4 tasks
Contributor
|
| Changeset | Package |
|---|---|
theme-check-json-contract.md |
'@shopify/cli': major |
theme-duplicate-json-contract.md |
'@shopify/cli': major |
theme-info-json-contract.md |
'@shopify/cli': major |
theme-list-json-contract.md |
'@shopify/cli': major |
theme-open-json-contract.md |
'@shopify/cli': major |
theme-preview-json-contract.md |
'@shopify/cli': major |
theme-profile-environments.md |
'@shopify/cli': major |
theme-push-json-contract.md |
"@shopify/cli": major |
Contributor
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/base-command.d.ts@@ -20,6 +20,7 @@ declare abstract class BaseCommand extends Command {
static descriptionWithoutMarkdown(): string | undefined;
static analyticsNameOverride(): string | undefined;
static analyticsStopCommand(): string | undefined;
+ private jsonOutputFromEnvironment;
catch(error: Error & {
skipOclifErrorHandling: boolean;
}): Promise<void>;
@@ -35,6 +36,7 @@ declare abstract class BaseCommand extends Command {
argv: string[];
}>;
protected environmentsFilename(): string | undefined;
+ protected validateNonTTYFlags(flags: FlagOutput): void;
protected failMissingNonTTYFlags(flags: FlagOutput, requiredFlags: string[]): void;
private failMissingNonTTYFlagRequirements;
private applicableNonTTYFlagRequirements;
packages/cli-kit/dist/public/node/themes/theme-manager.d.ts@@ -11,5 +11,12 @@ export declare abstract class ThemeManager {
findOrCreate(name?: string, role?: Role): Promise<Theme>;
fetch(name?: string, role?: Role): Promise<Theme | undefined>;
generateThemeName(context: string): string;
- create(themeRole?: Role, themeName?: string): Promise<Theme>;
+ create(themeRole?: Role, themeName?: string): Promise<{
+ createdAtRuntime: boolean;
+ id: number;
+ name: string;
+ processing: boolean;
+ role: string;
+ src?: string;
+ }>;
}
\ No newline at end of file
|
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Metafield downloads need structured outcomes and discoverable JSON support.
WHAT is this pull request doing?
Return strict flattened definitions, absolute artifact paths and explicit success/partial/skipped/cancelled outcomes. Preserve the native owner-keyed metafields.json file, successful downloads and owner-type failures; include a minor changeset for newly added theme JSON flags.
The public output follows
docs/cli/json-output.md; explicitly named environments use one{environments: [...]}object.How to manually test your changes?
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add