Repository navigation
Add typed JSON output to theme list - #8641
Merged
gonzaloriestra merged 5 commits intoOct 15, 2026
Merged
Conversation
gonzaloriestra
force-pushed
the
gonzalo/json-theme-list
branch
from
September 24, 2026 10:04
095fe47 to
fd69066
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-list
branch
2 times, most recently
from
September 24, 2026 10:25
479bc56 to
bfe48a7
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-list
branch
from
September 24, 2026 11:56
bfe48a7 to
3b51bcf
Compare
gonzaloriestra
marked this pull request as ready for review
September 24, 2026 14:13
gonzaloriestra
force-pushed
the
gonzalo/json-theme-list
branch
2 times, most recently
from
September 25, 2026 12:28
1ced35d to
fb8ea3a
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-list
branch
2 times, most recently
from
September 28, 2026 10:25
964ae97 to
69e125b
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-list
branch
from
September 28, 2026 11:39
69e125b to
b5ce60d
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-list
branch
2 times, most recently
from
September 29, 2026 10:28
49c6245 to
696f8e2
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-list
branch
from
October 8, 2026 09:53
c3ac545 to
2811e13
Compare
gonzaloriestra
marked this pull request as ready for review
October 8, 2026 10:03
gonzaloriestra
force-pushed
the
gonzalo/json-theme-list
branch
from
October 9, 2026 12:00
2811e13 to
f651b2a
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-list
branch
2 times, most recently
from
October 9, 2026 12:48
9bbdc28 to
f6ad2b2
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-list
branch
from
October 9, 2026 13:09
f6ad2b2 to
eeb721c
Compare
karreiro
approved these changes
Oct 13, 2026
karreiro
left a comment
Contributor
There was a problem hiding this comment.
Thank you, @gonzaloriestra!
gonzaloriestra
force-pushed
the
gonzalo/json-theme-list
branch
from
October 14, 2026 08:08
eeb721c to
e814881
Compare
isaacroldan
reviewed
Oct 15, 2026
isaacroldan
approved these changes
Oct 15, 2026
gonzaloriestra
force-pushed
the
gonzalo/json-theme-list
branch
from
October 15, 2026 09:56
e814881 to
aad224a
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-list
branch
2 times, most recently
from
October 15, 2026 10:42
f75d05a to
0239ea4
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-list
branch
from
October 15, 2026 11:49
0239ea4 to
dc2036a
Compare
Contributor
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/base-command.d.ts@@ -35,6 +35,7 @@ declare abstract class BaseCommand extends Command {
argv: string[];
}>;
protected environmentsFilename(): string | undefined;
+ protected validateNonTTYFlags(flags: FlagOutput): void;
protected failMissingNonTTYFlags(flags: FlagOutput, requiredFlags: string[]): void;
private failMissingNonTTYFlagRequirements;
private applicableNonTTYFlagRequirements;
|
Contributor
|
| Changeset | Package |
|---|---|
theme-info-json-contract.md |
'@shopify/cli': major |
theme-list-json-contract.md |
'@shopify/cli': major |
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Scripts need a stable theme collection contract.
WHAT is this pull request doing?
Return a named themes array with string IDs and public fields, excluding internal runtime state. Retain every requested environment and fail when any requested work fails.
The public output follows
docs/cli/json-output.md; explicitly named environments use one{environments: [...]}object.How to manually test your changes?
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add