Repository navigation
Add typed JSON output to theme publish - #8652
Merged
gonzaloriestra merged 5 commits intoOct 15, 2026
Merged
Conversation
gonzaloriestra
added this pull request to stack #8654
September 24, 2026 09:47
gonzaloriestra
force-pushed
the
gonzalo/json-theme-publish
branch
from
September 24, 2026 10:04
d3213d0 to
789a14a
Compare
gonzaloriestra
removed this pull request from stack #8654
September 24, 2026 10:04
gonzaloriestra
added this pull request to stack #8655
September 24, 2026 10:05
gonzaloriestra
force-pushed
the
gonzalo/json-theme-publish
branch
from
September 24, 2026 10:13
789a14a to
bcdcb7d
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-publish
branch
from
September 24, 2026 10:25
bcdcb7d to
56a75f3
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-publish
branch
from
September 24, 2026 11:56
56a75f3 to
15a4930
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-publish
branch
2 times, most recently
from
September 24, 2026 14:21
0adfd99 to
5ba599e
Compare
gonzaloriestra
marked this pull request as ready for review
September 24, 2026 14:34
gonzaloriestra
force-pushed
the
gonzalo/json-theme-publish
branch
from
September 24, 2026 14:36
5ba599e to
51ec362
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-publish
branch
from
September 25, 2026 12:28
51ec362 to
46ed754
Compare
gonzaloriestra
removed this pull request from stack #8655
September 25, 2026 12:28
gonzaloriestra
added this pull request to stack #8673
September 25, 2026 12:29
gonzaloriestra
force-pushed
the
gonzalo/json-theme-publish
branch
from
September 28, 2026 08:20
46ed754 to
f8d5e61
Compare
gonzaloriestra
marked this pull request as draft
October 6, 2026 12:18
gonzaloriestra
force-pushed
the
gonzalo/json-theme-publish
branch
from
October 6, 2026 12:29
065a1ec to
2c531be
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-publish
branch
from
October 6, 2026 12:31
2c531be to
1523653
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-publish
branch
from
October 6, 2026 13:53
1523653 to
d3b8376
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-publish
branch
from
October 8, 2026 08:43
d3b8376 to
3644e3d
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-publish
branch
from
October 8, 2026 09:53
3644e3d to
8aefc17
Compare
gonzaloriestra
marked this pull request as ready for review
October 8, 2026 10:04
gonzaloriestra
force-pushed
the
gonzalo/json-theme-publish
branch
from
October 9, 2026 12:00
8aefc17 to
ff6543b
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-publish
branch
from
October 9, 2026 12:26
ff6543b to
572dd63
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-publish
branch
from
October 9, 2026 12:48
572dd63 to
9fd693d
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-publish
branch
from
October 9, 2026 13:09
9fd693d to
04c1a78
Compare
karreiro
approved these changes
Oct 14, 2026
karreiro
left a comment
Contributor
There was a problem hiding this comment.
Thank you, @gonzaloriestra!
Contributor
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/base-command.d.ts@@ -35,6 +35,7 @@ declare abstract class BaseCommand extends Command {
argv: string[];
}>;
protected environmentsFilename(): string | undefined;
+ protected validateNonTTYFlags(flags: FlagOutput): void;
protected failMissingNonTTYFlags(flags: FlagOutput, requiredFlags: string[]): void;
private failMissingNonTTYFlagRequirements;
private applicableNonTTYFlagRequirements;
|
3 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Theme publishing needs a typed automation result.
WHAT is this pull request doing?
Add strict JSON mutation resources with string IDs, nullable source URLs and status/changed outcomes. Preserve cancellation and every explicit environment result.
The public output follows
docs/cli/json-output.md; explicitly named environments use one{environments: [...]}object.How to manually test your changes?
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add