Repository navigation
added: NonLinMPC now supports NonLinModelDAE 🥳🍾 - #470
Merged
Merged
Conversation
It is now documented in the "Internals -> Misc" section
The estimation horizon `He` still needs to be explicitly defined in the keyword arguments.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #470 +/- ##
==========================================
- Coverage 97.21% 97.17% -0.04%
==========================================
Files 28 28
Lines 6863 6985 +122
==========================================
+ Hits 6672 6788 +116
- Misses 191 197 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
It's better to be explicit on the multiple dispatch.
Benchmark Results (Julia v1)Time benchmarks
Memory benchmarks
|
Member
Author
|
No impact on existing collocation benchmakrs, except |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both the
TrapezoidalCollocationand theOrthogonalCollocationtranscriptions are supported.The default state estimator is a
MovingHorizonEstimatorforNonLinMPCconstructed onNonLinModelDAE. But the estimation horizon must be explicitly defined with theHekeyword arguments since there is no default value. This is also the case for theHpkeyword argument.