Repository navigation
merge queue: checking #1360 on main (2f93d6c), stacked on 4 pull requests ahead - #1362
Closed
mergify[bot] wants to merge 12 commits into
Closed
mergify[bot] wants to merge 12 commits into
mergify[bot] wants to merge 12 commits into
Conversation
tests/test_install.py and engine/hooks/_runner/tests/test_wrap_installed.py asserted one settings entry per hook, so every per-hook guarantee they check failed once CATSTACK_HOOK_DISPATCHER (#1122) collapsed an event to a single _runner/dispatch.py entry: 70 failures and 1 error on #1122's head, all in these two files. load_config() in tests/test_install.py now reads an installed config and expands a collapsed event back into one entry per hook, resolving each hook's registration the way dispatch.py itself does (dispatch.load_event_hooks: the cursor registry, or the hook's own manifest for claude and codex). Each assertion therefore sees the identical shape in both layouts and keeps checking the same guarantee -- right event, right harness, Stop mirrored to SubagentStop or opted out, dead entries pruned, non-catstack entries untouched. test_wrap_installed.py's fixture pins the flag off, since it asserts the settings bytes install writes rather than a hook's registration. #1122's own test_default_is_off_and_byte_identical_to_no_flag_at_all now compares the default install against an install that sets the flag to whatever flags.py resolves as the default, and clears the key from its own environment first, so the flag-on run of the full suite cannot leak into the "default" side of the comparison. The CATSTACK_HOOK_DISPATCHER default is left off. Flipping it on is gated on both full-suite runs passing, and the source branch plan/hook-backlog-1c-install-tests-accept-the-one-entry-per-event-layout-default-on-only-if-both-suites-pass never changed engine/hooks/_flags/flags.py, so that gate was not met there and this commit does not claim it. Cherry-picked from 6330abf on that branch. The branch's two other content commits (engine/hooks/_runner/doctor.py, scripts/test/run_skill_scenarios.py) are unrelated to this claim and are left behind.
…ew claim: tests.test_install and test_wrap_installed accept both install layouts (one entry per hook with CATSTACK_HOOK_DISPATCHER off, one dispatcher entry per event with it on), and the flag defaults to on only if bash scripts/test/run_all_tests.sh passes with the flag on and off. Review lane: behavior Safety invariant: If either suite run fails, the default stays off. Per-hook guarantees stay checked in the dispatcher layout. Files: tests/test_install.py, tests/test_wrap_installed.py Change types: test Acceptance criteria: This workflow publishes one pull request for the install-layout claim only. Exit code: 0 Invoker-Finalize-Id: f459f9c9-a623-4fd7-9708-21cc3ae4cbda
…s/g0.t0.a-a464d403f-4908b6a4 — Review claim: tests.test_install and test_wrap_installed accept both install layouts (one entry per hook with CATSTACK_HOOK_DISPATCHER off, one dispatcher entry per event with it on), and the flag defaults to on only if bash scripts/test/run_all_tests.sh passes with the flag on and off. Review lane: behavior Safety invariant: If either suite run fails, the default stays off. Per-hook guarantees stay checked in the dispatcher layout. Files: tests/test_install.py, tests/test_wrap_installed.py Change types: test Acceptance criteria: This workflow publishes one pull request for the install-layout claim only.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Change-Id: Id0dec9283a11dc8cf7089f236efd154b5d84b090
…r readable output Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Change-Id: I3e4aace7fa476750c7f5c3f9e64f4ba39b39c8b4
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Change-Id: Ib18c9dab334aef5e6428f0eb4367d07c2c869b64
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Change-Id: I69aa5ab27060da00fd801ddf841b1058bc3bd0a7
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
⏳ The pull request #1360 is queued for merge and currently being checked. ⏳
#1360 is queued for merge on branch main (2f93d6c).
Stacked behind 4 pull requests queued ahead of this batch, not part of it. These checks run on a tip that also carries their commits, so a failure here can come from them as much as from #1360.
Queued ahead of this batch:
This pull request has been created by Mergify to speculatively check the mergeability of #1360.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.
Required conditions of queue rule
admin-bypassfor merge:check-success = testcheck-success = lintcheck-success = validateRequired conditions to stay in the queue:
-draftbase=mainlabel=admin-bypass