Skip to content

Add ci-job-timing skill: per-step timing report from Datadog - #1354

Merged
mergify[bot] merged 1 commit into
mainfrom
stack/EdbertChan/cjt-3-context/add-ci-job-timing-skill-per-step-timing-report--d0dec928
Oct 13, 2026
Merged

mergify[bot] merged 1 commit into
mainfrom
stack/EdbertChan/cjt-3-context/add-ci-job-timing-skill-per-step-timing-report--d0dec928

Conversation

@EdbertChan

@EdbertChan EdbertChan commented Oct 12, 2026 •

Copy link
Copy Markdown
Owner

Summary

Slow CI jobs are hard to speed up when nobody knows where the time goes. This adds a report listing each job step and its time.

The report reads step timings that Datadog already stores. It prints a table and a link to the same query.

It also adds the skill to the shared skill list, because the repo's check needs both together.

Review Claim

Approve a read-only report that shows how long each step of a CI job takes, using Datadog data.

Review Lane

behavior

Review Unit

product-skill

Safety Invariant

It only reads Datadog and GitLab. The token comes from the environment and is never printed or saved.

Slice Rationale

This is the first of two slices. The skill's list entry ships with it. The repo's registry check fails for a skill missing from the list, so the two cannot be separated:

without the entry (CI log, merge queue run): FAIL skill directory not in skills.toml: product/skills/ci-job-timing
with the entry (this pull request):          ok 60 skills in skills.toml match disk

Non-goals

  • No change to how CI jobs run.
  • No writes to Datadog or GitLab.
  • No second report; that comes in the next slice.

Measured

none: this adds a new report and nothing existing to compare against

Test Plan

Test Plan
  • python3 -m unittest product/skills/ci-job-timing/tests/test_ci_job_timing.py printed Ran 8 tests ... OK
  • python3 engine/skills/make-pr/scripts/preflight.py --base origin/main --dry-run printed unit product-skill: 3 file(s), neutral 1 file(s): skills.toml and ok preflight passed
  • python3 scripts/ci/check_skills_registry.py, check_skills_three_harnesses.py, check_ecosystem_boundaries.py, check_skill_file_refs.py, check_skill_test_coverage.py --base origin/main --head HEAD, check_skill_test_debt_no_growth.py, check_skill_trigger_mechanism.py, check_no_dated_provenance.py --base origin/main, check_no_new_comments.py --base origin/main, check_hook_test_coverage.py, check_no_silent_hook_except.py, check_rules_are_wired.py and check_no_tracked_local_artifacts.py each exited 0 on both commits
  • Not run: the full run every tests/ dir step. Blocker: it takes about 54 minutes and runs in CI on this pull request
  • Not run: a live query against Datadog. Blocker: it needs live Datadog access, which was not used for this slice
  • Fixture vs live: the tests above use fixtures only; no live side effect was exercised

Revert Plan

Revert Plan
  • Safe to revert? Yes
  • Revert command: git revert <sha>
  • Post-revert steps: None
  • Data migration? No

🤖 Generated with Claude Code

@EdbertChan
EdbertChan added this pull request to stack #1357 October 12, 2026 19:30
@cursor

cursor Bot commented Oct 12, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: 1977db8e-0817-422b-adea-e91dc1adaa08)

@EdbertChan EdbertChan changed the title Add ci-job-timing skill: per-step timing report from Datadog Add a report of how long each CI job step takes Oct 12, 2026
@mergify

mergify Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Queued — the merge queue status continues in this comment ↓.

@EdbertChan

Copy link
Copy Markdown
Owner Author

@Mergifyio queue

@mergify

mergify Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Merge Queue Status

This pull request spent 2 hours 2 minutes 47 seconds in the queue, including 1 hour 35 minutes 50 seconds running CI.

Reason

The merge conditions cannot be satisfied due to failing checks

  • test

Failing checks:

Hint

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio queue comment.

Waiting for
  • check-success = test
All conditions
  • check-success = test
  • check-success = lint
  • check-success = validate

Requeued — the merge queue status continues in this comment ↓.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Change-Id: Id0dec9283a11dc8cf7089f236efd154b5d84b090
@cursor

cursor Bot commented Oct 13, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: e67f17cc-93fa-4aa7-ac21-c0790f0fa04a)

@EdbertChan
EdbertChan removed this pull request from stack #1357 October 13, 2026 04:06
@EdbertChan EdbertChan changed the title Add a report of how long each CI job step takes Add ci-job-timing skill: per-step timing report from Datadog Oct 13, 2026
@EdbertChan
EdbertChan force-pushed the stack/EdbertChan/cjt-3-context/add-ci-job-timing-skill-per-step-timing-report--d0dec928 branch from e93ea17 to 44d8782 Compare October 13, 2026 04:06
@EdbertChan

Copy link
Copy Markdown
Owner Author

Revision history

# Type Changes Reason Date
1 initial e93ea17 2026-10-13 04:06 UTC
2 unknown e93ea17 → 44d8782 2026-10-13 04:06 UTC

@EdbertChan
EdbertChan added this pull request to stack #1375 October 13, 2026 04:06
@cursor

cursor Bot commented Oct 13, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: bdde7ff2-73ee-4a84-baf0-99d317e0d28c)

@EdbertChan

Copy link
Copy Markdown
Owner Author

@Mergifyio queue

@mergify

mergify Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Merge Queue Status

This pull request spent 1 hour 43 minutes 44 seconds in the queue, including 1 hour 42 minutes 48 seconds running CI.

Required conditions to merge
  • check-success = lint
  • check-success = test
  • check-success = validate

@EdbertChan

Copy link
Copy Markdown
Owner Author

Mergify repair stopped: PR #1354 is ready to land, but upper stack PR(s) #1356 are open without admin-bypass; a human must decide whether to include them in the admin-bypass landing stack or land them separately.

@mergify
mergify Bot merged commit e4d3d1b into main Oct 13, 2026
5 of 9 checks passed
@mergify mergify Bot removed the queued label Oct 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant