Repository navigation
Plan first: build an approved mock before planning data collection for readable output - #1358
Merged
Conversation
…r readable output Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Change-Id: I3e4aace7fa476750c7f5c3f9e64f4ba39b39c8b4
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: 701c06bc-f186-45a7-82f1-82e764059720) |
Contributor
|
Queued — the merge queue status continues in this comment ↓. |
Owner
Author
|
@Mergifyio queue |
Contributor
Merge Queue Status
This pull request spent 2 hours 54 minutes 1 second in the queue, including 1 hour 42 minutes 19 seconds running CI. Required conditions to merge
|
This was referenced Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a task produces something a person will read, the agent often builds the data collector first. The reader then sees the result last and asks for changes.
This adds one step to the planning guide. Build a mock on fake data first. Agree on what is shown and what each number means.
Only then plan the real data work.
Review Claim
Approve a planning step that asks for an approved mock before any data collection is planned, whenever the output is meant to be read.
Review Lane
behavior
Review Unit
product-skill
Safety Invariant
It adds guidance text and one example. No code runs differently, and removing the paragraph restores the old guide.
Slice Rationale
This is a separate claim from the Invoker gate and from the hand-back rule, and it lives in a different review unit.
Non-goals
Measured
none: this adds guidance text; there is no number to measure
Test Plan
Test Plan
python3 scripts/ci/check_skill_test_coverage.py --base origin/main --head HEADprintedok skill test coveragepython3 scripts/ci/check_no_dated_provenance.py --base origin/mainprintedok no dated provenancepython3 scripts/ci/check_skills_three_harnesses.py,check_ecosystem_boundaries.py,check_skill_file_refs.py,check_skill_trigger_policy.pyandcheck_skill_trigger_mechanism.pyeach exited 0python3 engine/skills/make-pr/scripts/preflight.py --base origin/main --dry-runprintedunit product-skill: 2 file(s)andok preflight passedRevert Plan
Revert Plan
git revert <sha>🤖 Generated with Claude Code