Repository navigation
cat-mode: align publishing-analytics fixture asserts with revised example phrasing. - #1311
Conversation
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: ce099b89-1224-4887-a7ee-87e4ce331d18) |
e88b694 to
8b6eb02
Compare
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: 2819f823-57ee-4a58-87e4-148357f0001e) |
…alidate) Exit code: 0
…rtChan/automate/dashboard-health-receipt/cat-mode-require-analytics-health-receipts--8efc336d Exit code: 0
8b6eb02 to
60dbd69
Compare
Phrase-judge rejected leads that named only the trigger phrase; state the split and the stop-first catch as the lesson, with the triggers as examples. Co-authored-by: Cursor <cursoragent@cursor.com> Change-Id: I7dad9e54f9d280bb4d8f41ac06662293e39c9e05
…mple phrasing. Co-authored-by: Cursor <cursoragent@cursor.com> Change-Id: Idebc0f0ba74e47864bf479446a8e27b0574cdcde
…est) Exit code: 0
…rtChan/automate/dashboard-health-receipt/cat-mode-lead-analytics-diagnosis-rules-general--7dad9e54 Exit code: 0
477d078 to
632eb92
Compare
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: 8672f040-c359-435b-9dd0-9cb1d163e636) |
|
Queued — the merge queue status continues in this comment ↓. |
|
@Mergifyio queue |
Merge Queue Status
This pull request spent 1 hour 1 minute 17 seconds in the queue, including 1 hour 55 seconds running CI. Required conditions to merge
|
Depends-On: #1310
Summary
The working-style guide has an analytics pause rule. It tells agents to stop adding analytics work when a required habit fix appears during churn.
The problem was drift. The main rule, the deeper note, and the fixture checks used different lead phrases for the same rule.
This slice uses one plain lead phrase in all three places. The examples stay the same.
Review Claim
Approve that the analytics pause rule uses one lead phrase across the guide, its deeper note, and its fixture checks.
Review Lane
behavior
Review Unit
corpus-lesson
Safety Invariant
This only rephrases one existing analytics checkpoint and updates the direct assertions that pin that text. The triggers, examples, and runtime code stay unchanged.
Slice Rationale
This slice keeps the fixture assertions aligned with the same rule wording in the skill prose.
Non-goals
Measured
Command:
node engine/skills/draft-pr/scripts/validate-pr-body.mjs --body-file <body> --changed-files-file <changed-files> --diff-file <diff>Test Plan
Test Plan
python3 -m unittest tests.test_cat_modepython3 engine/skills/make-pr/scripts/preflight.py --base origin/stack/EdbertChan/automate/dashboard-health-receipt/cat-mode-lead-analytics-diagnosis-rules-general--7dad9e54 --commit-only --dry-runpython3 scripts/ci/check_codify_has_code.py --base origin/stack/EdbertChan/automate/dashboard-health-receipt/cat-mode-lead-analytics-diagnosis-rules-general--7dad9e54 && python3 scripts/ci/check_no_dated_provenance.py --base origin/stack/EdbertChan/automate/dashboard-health-receipt/cat-mode-lead-analytics-diagnosis-rules-general--7dad9e54 && python3 engine/skills/make-pr/scripts/rule_scope_check.py --base origin/stack/EdbertChan/automate/dashboard-health-receipt/cat-mode-lead-analytics-diagnosis-rules-general--7dad9e54python3 scripts/ci/check_skills_three_harnesses.py && python3 scripts/ci/check_ecosystem_boundaries.py && python3 scripts/ci/check_skill_file_refs.pypython3 scripts/ci/check_skill_test_coverage.py --base origin/stack/EdbertChan/automate/dashboard-health-receipt/cat-mode-lead-analytics-diagnosis-rules-general--7dad9e54 --head HEAD && python3 scripts/ci/check_skill_trigger_mechanism.py && python3 scripts/ci/check_skill_trigger_policy.py && python3 scripts/ci/check_subagent_scope_contract.pypython3 -m ruff check --select E9,F tests/test_cat_mode.pypython3 scripts/test/run_skill_scenarios.pynode engine/skills/draft-pr/scripts/validate-pr-body.mjs --body-file /tmp/pr1311-body.md --changed-files-file <changed-files> --diff-file <diff>Revert Plan
Revert Plan
git revert 632eb923a55893e6207c3e868920ec5895f78d81python3 -m unittest tests.test_cat_mode.