Skip to content

cat-mode: align publishing-analytics fixture asserts with revised example phrasing. - #1311

Merged
mergify[bot] merged 9 commits into
mainfrom
stack/EdbertChan/automate/dashboard-health-receipt/cat-mode-align-publishing-analytics-fixture--debc0f0b
Oct 13, 2026
Merged

mergify[bot] merged 9 commits into
mainfrom
stack/EdbertChan/automate/dashboard-health-receipt/cat-mode-align-publishing-analytics-fixture--debc0f0b

Conversation

@EdbertChan

@EdbertChan EdbertChan commented Oct 8, 2026 •

Copy link
Copy Markdown
Owner

Depends-On: #1310

Summary

The working-style guide has an analytics pause rule. It tells agents to stop adding analytics work when a required habit fix appears during churn.

The problem was drift. The main rule, the deeper note, and the fixture checks used different lead phrases for the same rule.

This slice uses one plain lead phrase in all three places. The examples stay the same.

Review Claim

Approve that the analytics pause rule uses one lead phrase across the guide, its deeper note, and its fixture checks.

Review Lane

behavior

Review Unit

corpus-lesson

Safety Invariant

This only rephrases one existing analytics checkpoint and updates the direct assertions that pin that text. The triggers, examples, and runtime code stay unchanged.

Slice Rationale

This slice keeps the fixture assertions aligned with the same rule wording in the skill prose.

Non-goals

  • Does not change analytics checkpoint triggers, automation policy, dashboard or backfill behavior, hook code, or runtime code.

Measured

Command: node engine/skills/draft-pr/scripts/validate-pr-body.mjs --body-file <body> --changed-files-file <changed-files> --diff-file <diff>

  • base:
PR body validation failed:
- Missing required section: ## Summary
- Missing required section: ## Non-goals
- Missing required section: ## Test Plan
- Missing required section: ## Revert Plan
- Missing review metadata. Add visible ## Review Claim / ## Review Lane / ## Review Unit / ## Safety Invariant / ## Slice Rationale sections.
- Missing required section: ## Measured. Give a `base:` row and a `head:` row, each with the repro command's real pasted output (inline in backticks, or in a code block under the row), or the single line `none: <reason>` when this slice has nothing to measure.
  • head:
PR body validation passed.

Test Plan

Test Plan
  • python3 -m unittest tests.test_cat_mode
Ran 166 tests in 1.439s

OK
  • python3 engine/skills/make-pr/scripts/preflight.py --base origin/stack/EdbertChan/automate/dashboard-health-receipt/cat-mode-lead-analytics-diagnosis-rules-general--7dad9e54 --commit-only --dry-run
unit    corpus-lesson: 2 file(s)
neutral 1 file(s): tests/test_cat_mode.py
declare Review Unit: corpus-lesson
ok      preflight passed
  • python3 scripts/ci/check_codify_has_code.py --base origin/stack/EdbertChan/automate/dashboard-health-receipt/cat-mode-lead-analytics-diagnosis-rules-general--7dad9e54 && python3 scripts/ci/check_no_dated_provenance.py --base origin/stack/EdbertChan/automate/dashboard-health-receipt/cat-mode-lead-analytics-diagnosis-rules-general--7dad9e54 && python3 engine/skills/make-pr/scripts/rule_scope_check.py --base origin/stack/EdbertChan/automate/dashboard-health-receipt/cat-mode-lead-analytics-diagnosis-rules-general--7dad9e54
ok      codify-has-code
ok      no dated provenance
ok      no incident-scoped rules
  • python3 scripts/ci/check_skills_three_harnesses.py && python3 scripts/ci/check_ecosystem_boundaries.py && python3 scripts/ci/check_skill_file_refs.py
ok      skills four-harness check
ok      ecosystem boundaries
ok      skill file refs
  • python3 scripts/ci/check_skill_test_coverage.py --base origin/stack/EdbertChan/automate/dashboard-health-receipt/cat-mode-lead-analytics-diagnosis-rules-general--7dad9e54 --head HEAD && python3 scripts/ci/check_skill_trigger_mechanism.py && python3 scripts/ci/check_skill_trigger_policy.py && python3 scripts/ci/check_subagent_scope_contract.py
ok      skill test coverage
ok      skill trigger mechanism
ok      skill trigger policy
ok      subagent scope contract
  • python3 -m ruff check --select E9,F tests/test_cat_mode.py
All checks passed!
  • python3 scripts/test/run_skill_scenarios.py
ok    all 18 scenario(s) behaved as declared
  • node engine/skills/draft-pr/scripts/validate-pr-body.mjs --body-file /tmp/pr1311-body.md --changed-files-file <changed-files> --diff-file <diff>
PR body validation passed.

Revert Plan

Revert Plan
  • Safe to revert? Yes.
  • Revert command: git revert 632eb923a55893e6207c3e868920ec5895f78d81
  • Post-revert steps: Re-run python3 -m unittest tests.test_cat_mode.
  • Data migration? No.

@cursor

cursor Bot commented Oct 8, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: ce099b89-1224-4887-a7ee-87e4ce331d18)

@EdbertChan
EdbertChan force-pushed the stack/EdbertChan/automate/dashboard-health-receipt/cat-mode-lead-analytics-diagnosis-rules-general--7dad9e54 branch from e88b694 to 8b6eb02 Compare October 12, 2026 18:20
@cursor

cursor Bot commented Oct 12, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: 2819f823-57ee-4a58-87e4-148357f0001e)

@EdbertChan
EdbertChan force-pushed the stack/EdbertChan/automate/dashboard-health-receipt/cat-mode-lead-analytics-diagnosis-rules-general--7dad9e54 branch from 8b6eb02 to 60dbd69 Compare October 13, 2026 03:00
EdbertChan and others added 4 commits October 13, 2026 03:09
Phrase-judge rejected leads that named only the trigger phrase; state the split and the stop-first catch as the lesson, with the triggers as examples.

Co-authored-by: Cursor <cursoragent@cursor.com>
Change-Id: I7dad9e54f9d280bb4d8f41ac06662293e39c9e05
…mple phrasing.

Co-authored-by: Cursor <cursoragent@cursor.com>
Change-Id: Idebc0f0ba74e47864bf479446a8e27b0574cdcde
…rtChan/automate/dashboard-health-receipt/cat-mode-lead-analytics-diagnosis-rules-general--7dad9e54

Exit code: 0
@EdbertChan
EdbertChan force-pushed the stack/EdbertChan/automate/dashboard-health-receipt/cat-mode-align-publishing-analytics-fixture--debc0f0b branch from 477d078 to 632eb92 Compare October 13, 2026 03:10
@cursor

cursor Bot commented Oct 13, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: 8672f040-c359-435b-9dd0-9cb1d163e636)

@mergify

mergify Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Queued — the merge queue status continues in this comment ↓.

@EdbertChan
EdbertChan changed the base branch from stack/EdbertChan/automate/dashboard-health-receipt/cat-mode-lead-analytics-diagnosis-rules-general--7dad9e54 to main October 13, 2026 07:03
@EdbertChan

Copy link
Copy Markdown
Owner Author

@Mergifyio queue

@mergify

mergify Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Merge Queue Status

This pull request spent 1 hour 1 minute 17 seconds in the queue, including 1 hour 55 seconds running CI.

Required conditions to merge

@mergify mergify Bot added the queued label Oct 13, 2026
@mergify
mergify Bot merged commit 4c092f7 into main Oct 13, 2026
6 of 8 checks passed
@mergify mergify Bot removed the queued label Oct 13, 2026
@mergify mergify Bot mentioned this pull request Oct 13, 2026
8 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant