Skip to content

cat-mode: treat intervention marker as proof wording. - #1310

Merged
mergify[bot] merged 6 commits into
mainfrom
stack/EdbertChan/automate/dashboard-health-receipt/cat-mode-lead-analytics-diagnosis-rules-general--7dad9e54
Oct 13, 2026
Merged

mergify[bot] merged 6 commits into
mainfrom
stack/EdbertChan/automate/dashboard-health-receipt/cat-mode-lead-analytics-diagnosis-rules-general--7dad9e54

Conversation

@EdbertChan

@EdbertChan EdbertChan commented Oct 8, 2026 •

Copy link
Copy Markdown
Owner

Summary

This keeps a personal working guide check aligned with the guide text.

The problem: the guide names an automation marker that is not a shipped skill. The checker could read that marker as a missing skill.

The fix: the checker treats that marker as process wording, so the guide can keep the marker without a false failure.

Review Claim

Approve the narrow proof update that treats the automation marker as process wording, not a missing skill.

Review Lane

proof

Review Unit

proof

Safety Invariant

This slice changes only one regression guard's allowlist for prose-shaped tokens; it does not change shipped guidance or runtime behavior.

Slice Rationale

The slice stays with the direct regression guard because the current branch contains only that proof file.

Non-goals

  • No shipped guidance changes.
  • No runtime behavior change.
  • No dashboard, backfill, or analytics query changes.
  • No skill installation or trigger policy changes.

Measured

none: this slice changes a prose regression guard, not a runtime metric.

Test Plan

Test Plan
  • python3 -m unittest tests.test_cat_mode.TestCatModeReferences.test_every_referenced_skill_still_exists -v
  • python3 -m ruff check --select E9,F tests/test_cat_mode.py
  • PATH=/tmp/pr1310-preflight:$PATH python3 engine/skills/make-pr/scripts/preflight.py --base origin/stack/EdbertChan/automate/dashboard-health-receipt/cat-mode-require-analytics-health-receipts--8efc336d --commit-only --body-file /tmp/pr1310-body.md
  • node engine/skills/draft-pr/scripts/validate-pr-body.mjs --body-file /tmp/pr1310-body.md --changed-files-file /tmp/pr1310-changed-files.txt

Revert Plan

Revert Plan
  • Safe to revert? Yes.
  • Revert command: git revert <merge-commit-sha>
  • Post-revert steps: None.
  • Data migration? No.

Depends-On: #1309


Note

Low Risk
Test-only allowlist tweak for a prose token; no production code, guidance, or runtime paths change.

Overview
Updates the test_every_referenced_skill_still_exists allowlist in tests/test_cat_mode.py so backticked intervention-must-automate in cat-mode prose is treated as process wording (an automation marker / flag example), not a shipped skill directory.

This keeps the structural regression guard aligned when SKILL.md names that marker (e.g. mid–analytics-thrash “lock the catch” examples) without reporting a false “missing skill.” No cat-mode guidance or runtime behavior changes—only the test exclusion set.

Reviewed by Cursor Bugbot for commit 9513ce7. Bugbot is set up for automated code reviews on this repo. Configure here.

@cursor

cursor Bot commented Oct 8, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: 4e455bce-d1eb-430b-b904-123a2a91330d)

@EdbertChan

Copy link
Copy Markdown
Owner Author

This pull request is part of a Mergify stack:

# Pull Request Link
1 cat-mode: require analytics health receipts before dashboard narratives. #1309
2 cat-mode: lead analytics diagnosis rules with the general lesson. #1310 👈
3 cat-mode: align publishing-analytics fixture asserts with revised example phrasing. #1311
4 cat-mode: lead the multi-emitter backfill done-gate with the general lesson. #1312
5 cat-mode: allowlist intervention-must-automate as a flag token. #1313
6 cat-mode: lead the thrash-stop default with the general catch lesson. #1314

@mergify

mergify Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Queued — the merge queue status continues in this comment ↓.

@EdbertChan
EdbertChan force-pushed the stack/EdbertChan/automate/dashboard-health-receipt/cat-mode-lead-analytics-diagnosis-rules-general--7dad9e54 branch from e88b694 to 8b6eb02 Compare October 12, 2026 18:20
@cursor

cursor Bot commented Oct 12, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: 7adc11a1-cc72-4876-b55e-dd25cb928e44)

@EdbertChan
EdbertChan force-pushed the stack/EdbertChan/automate/dashboard-health-receipt/cat-mode-require-analytics-health-receipts--8efc336d branch from 737c66d to 6d95b2a Compare October 12, 2026 23:15
@EdbertChan
EdbertChan force-pushed the stack/EdbertChan/automate/dashboard-health-receipt/cat-mode-lead-analytics-diagnosis-rules-general--7dad9e54 branch from 8b6eb02 to 60dbd69 Compare October 13, 2026 03:00
@cursor

cursor Bot commented Oct 13, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: 0dd50f57-1449-4436-b581-950ffc860cef)

@EdbertChan EdbertChan changed the title cat-mode: lead analytics diagnosis rules with the general lesson. cat-mode: treat intervention marker as proof wording. Oct 13, 2026
@cursor

cursor Bot commented Oct 13, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: 6023f4a3-6d62-401b-ab15-45d368d7f8c3)

@EdbertChan
EdbertChan changed the base branch from stack/EdbertChan/automate/dashboard-health-receipt/cat-mode-require-analytics-health-receipts--8efc336d to main October 13, 2026 05:34
@EdbertChan

Copy link
Copy Markdown
Owner Author

@Mergifyio queue

@mergify

mergify Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Merge Queue Status

This pull request spent 1 hour 14 minutes 37 seconds in the queue, including 49 minutes 23 seconds running CI.

Required conditions to merge

@mergify mergify Bot added the queued label Oct 13, 2026
@mergify
mergify Bot merged commit 1eb2105 into main Oct 13, 2026
8 checks passed
@mergify mergify Bot removed the queued label Oct 13, 2026
mergify Bot pushed a commit that referenced this pull request Oct 13, 2026
…mple phrasing. (#1311)

* invoker: wf-1791829352374-46/repair — Rebase PR #1309 onto main

Exit code: 0

* Fix cat-mode reference gate flag token

* invoker: wf-1791746481991-3/repair — Repair PR #1309 (failed check test)

Exit code: 0

* invoker: wf-1791822744313-30/repair — Repair PR #1310 (failed check validate)

Exit code: 0

* invoker: wf-1791850959113-81/repair — Rebase PR #1310 onto stack/EdbertChan/automate/dashboard-health-receipt/cat-mode-require-analytics-health-receipts--8efc336d

Exit code: 0

* cat-mode: lead analytics diagnosis rules with the general lesson.

Phrase-judge rejected leads that named only the trigger phrase; state the split and the stop-first catch as the lesson, with the triggers as examples.

Co-authored-by: Cursor <cursoragent@cursor.com>
Change-Id: I7dad9e54f9d280bb4d8f41ac06662293e39c9e05

* cat-mode: align publishing-analytics fixture asserts with revised example phrasing.

Co-authored-by: Cursor <cursoragent@cursor.com>
Change-Id: Idebc0f0ba74e47864bf479446a8e27b0574cdcde

* invoker: wf-1791828161279-44/repair — Repair PR #1311 (failed check test)

Exit code: 0

* invoker: wf-1791860491047-92/repair — Rebase PR #1311 onto stack/EdbertChan/automate/dashboard-health-receipt/cat-mode-lead-analytics-diagnosis-rules-general--7dad9e54

Exit code: 0

---------

Co-authored-by: CI Bot <ci@invoker.dev>
Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant