Repository navigation
cat-mode: require analytics health receipts before dashboard narratives. - #1309
Conversation
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: d67aa41c-a418-474c-a151-b06472ca8d1b) |
|
This pull request is part of a Mergify stack:
|
|
Queued — the merge queue status continues in this comment ↓. |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: 8d203fda-ad92-4974-be3b-0865aa944ba5) |
|
@Mergifyio queue |
Merge Queue Status
This pull request spent 3 hours 29 minutes 55 seconds in the queue, including 1 hour 43 minutes running CI. ReasonPull request #1309 has been dequeued GitHub refused to merge the pull request. Pull Request has merge conflicts. This is usually enforced by a branch protection or ruleset rule. HintYou should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. Required conditions to merge
Requeued — the merge queue status continues in this comment ↓. |
737c66d to
6d95b2a
Compare
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: 3af7d3d8-f448-45ae-bcd3-e3221ebc8eec) |
|
@Mergifyio queue |
Merge Queue Status
This pull request spent 1 hour 55 seconds in the queue, including 1 hour 32 seconds running CI. ReasonThe merge conditions cannot be satisfied: the checks did not pass within the checks timeout of 1 hour These checks were still running:
Failing checks: HintYou may have to fix your CI before adding the pull request to the queue again. If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again. Waiting for
All conditions
Requeued — the merge queue status continues in this comment ↓. |
|
@Mergifyio queue |
Merge Queue Status
This pull request spent 46 minutes 46 seconds in the queue, including 46 minutes 24 seconds running CI. Required conditions to merge
|
* invoker: wf-1791829352374-46/repair — Rebase PR #1309 onto main Exit code: 0 * Fix cat-mode reference gate flag token * invoker: wf-1791746481991-3/repair — Repair PR #1309 (failed check test) Exit code: 0 * invoker: wf-1791822744313-30/repair — Repair PR #1310 (failed check validate) Exit code: 0 * invoker: wf-1791850959113-81/repair — Rebase PR #1310 onto stack/EdbertChan/automate/dashboard-health-receipt/cat-mode-require-analytics-health-receipts--8efc336d Exit code: 0 * invoker: wf-1791861093716-94/repair — Repair PR #1310 (failed check validate) Exit code: 0 --------- Co-authored-by: CI Bot <ci@invoker.dev>
…mple phrasing. (#1311) * invoker: wf-1791829352374-46/repair — Rebase PR #1309 onto main Exit code: 0 * Fix cat-mode reference gate flag token * invoker: wf-1791746481991-3/repair — Repair PR #1309 (failed check test) Exit code: 0 * invoker: wf-1791822744313-30/repair — Repair PR #1310 (failed check validate) Exit code: 0 * invoker: wf-1791850959113-81/repair — Rebase PR #1310 onto stack/EdbertChan/automate/dashboard-health-receipt/cat-mode-require-analytics-health-receipts--8efc336d Exit code: 0 * cat-mode: lead analytics diagnosis rules with the general lesson. Phrase-judge rejected leads that named only the trigger phrase; state the split and the stop-first catch as the lesson, with the triggers as examples. Co-authored-by: Cursor <cursoragent@cursor.com> Change-Id: I7dad9e54f9d280bb4d8f41ac06662293e39c9e05 * cat-mode: align publishing-analytics fixture asserts with revised example phrasing. Co-authored-by: Cursor <cursoragent@cursor.com> Change-Id: Idebc0f0ba74e47864bf479446a8e27b0574cdcde * invoker: wf-1791828161279-44/repair — Repair PR #1311 (failed check test) Exit code: 0 * invoker: wf-1791860491047-92/repair — Rebase PR #1311 onto stack/EdbertChan/automate/dashboard-health-receipt/cat-mode-lead-analytics-diagnosis-rules-general--7dad9e54 Exit code: 0 --------- Co-authored-by: CI Bot <ci@invoker.dev> Co-authored-by: Cursor <cursoragent@cursor.com>
Summary
Agents answer dashboard health questions with stories from charts. Those stories skip a receipt that names volume, fill, resolve, and filter for each harness and action.
Without that split, chart patches and blank-include filters look like fixes while emit or resolve still owns the gap. Feature thrash continues after the class should already be locked.
Adds standing defaults: health receipt first, prove live resolve before chart workarounds, full-backfill done only with a matrix plus fill table, and stop feature work when automate is mandated.
Review Claim
Approve standing analytics defaults that require a health receipt and an ownership split across volume, fill, resolve, and filter before dashboard narratives or insight patches, and that lock the class catch before more analytics feature work once automate is mandated.
Review Lane
behavior
Review Unit
corpus-lesson
Safety Invariant
These standing defaults change agent working style only. They do not change hook emit, resolve, backfill, or dashboard product code.
Assumptions: Safety Invariant unconfirmed (non-interactive publish).
Slice Rationale
One cat-mode prose update plus structural fixtures and unit assertions. Product resolve fix stays on its own open PR.
Non-goals
Measured
base:
python3 -m unittest tests.test_cat_mode.TestPublishingAnalyticsDefaults tests.test_cat_mode.TestAnalyticsThrashCheckpoints— prior suite shape without health-receipt / blank-include / matrix / automate-stop fixtureshead: same command →
Ran 17 tests in 0.004s/OKpreflight:
python3 engine/skills/make-pr/scripts/preflight.py --base origin/main --commit-only --body-file …→ rule-scopeok no incident-scoped rules; remaining gates green after body restoreTest Plan
Test Plan
python3 -m unittest tests.test_cat_mode.TestPublishingAnalyticsDefaults tests.test_cat_mode.TestAnalyticsThrashCheckpoints tests.test_cat_mode.TestCatModeReferences— Ran 17 tests in 0.004s, OKpython3 engine/skills/make-pr/scripts/rule_scope_check.py --base origin/main—ok no incident-scoped rulesRevert Plan
Revert Plan
Revert the commits on the branch, or close the PR without merging.
Note
Low Risk
Corpus-lesson and test-only changes to agent working defaults; explicitly does not alter analytics emit, resolve, or dashboard product code.
Overview
Extends
cat-modeagent guidance so dashboard/analytics work starts with a health receipt (harness×action counts andfilled_model_rate, with volume vs fill vs resolve vs filter ownership) instead of chart narratives or insight patches.New standing rules in
SKILL.mdandreferences/verify.mdtreat blank/synthetic models as emit/resolve defects (not chart filters or blank-include workarounds), require a harness×source matrix plus fill table for multi-emitter backfills, and mandate install + live probe before trusting published metrics. Related thrash guidance pauses feature PRs until a mid-thrash working-style catch is locked when automate is mandated.Regression coverage adds
TestPublishingAnalyticsDefaults, scenario fixtures undercorpus/skills/cat-mode/tests/, and assertions that the verify reference carries the full publishing-analytics text. No hook, resolve, backfill, or dashboard product code changes.Reviewed by Cursor Bugbot for commit 6d95b2a. Bugbot is set up for automated code reviews on this repo. Configure here.