Repository navigation
test: run pnpm directly in the pnpm workspace state e2e steps - #839
Merged
Merged
Conversation
fspy benchmarklinuxmacoswindows |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
The install and recheck steps ran pnpm through `vt run --no-cache` tasks. Running it directly failed on Windows: portable-pty's PATH search takes an exact name before trying `PATHEXT` extensions, so it picked pnpm's extensionless shell shim in `node_modules/.bin` over `pnpm.cmd`, which Windows can't execute. The harness now resolves programs other than `vt` and `vtt` with `which::which_in`, as `vp` resolves task programs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The harness canonicalizes its temp directory, which gives verbatim (`\\?\D:\...`) paths on Windows. `cmd.exe`, which runs npm-style `.cmd` shims such as pnpm's, rejects those as a working directory, so the direct `pnpm` steps failed with "UNC paths are not supported". Programs other than `vt` and `vtt` now start in the same directory without the verbatim prefix. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
`dunce::simplified` drops the verbatim prefix only when the path means the same without it, for example not past the legacy `MAX_PATH` limit or with reserved names, and is a no-op off Windows. It replaces the hand-written prefix stripping. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
wan9chi
force-pushed
the
claude/pnpm-direct-steps
branch
from
October 12, 2026 07:01
68855ec to
587b0ec
Compare
wan9chi
added this pull request to stack #842
October 12, 2026 07:06
wan9chi
added a commit
that referenced
this pull request
Oct 12, 2026
## Motivation The `remote_cache` and `remote_cache_backend` e2e tests were skipped on Windows because the e2e harness couldn't launch `remote-cache-server`, a pnpm command shim in `vite-task-tools`. #839 makes the harness resolve `.cmd` shims the way `vp` does and start them outside the verbatim temp path, so these tests can run on Windows too. ## Changes - Remove `cfg = "not(windows)"` from the `remote_cache` and `remote_cache_backend` cases, along with the comments that explained the skip. - `remote-cache-server` starts its command with `cross-spawn` instead of Node's `spawn`, which can't run pnpm's `.cmd` shims on Windows (`spawn cbor-http ENOENT`). `cross-spawn` and `@types/cross-spawn` are added to `vite-task-tools` through the catalog. - `pending_uploads` and `hide_pending_uploads` stay skipped on Windows, now for a different, documented reason. A milestone there is the console title, and ConPTY sends only the latest title when it next renders. In `pending_uploads`, the proxy's `stalled` milestone for the second upload can replace `uploads-pending`. In `hide_pending_uploads`, nothing is printed after it. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The
pnpm_workspace_statee2e test ranpnpm installand the dependency recheck throughvt run --no-cachetasks rather than as plain steps, because runningpnpmdirectly from the harness didn't work on Windows, for two reasons:PATHEXTextensions. pnpm'snode_modules/.binhas an extensionless shell shim namedpnpmnext topnpm.cmd, so the harness picked the shell script, which Windows can't execute.\\?\D:\...) paths on Windows.cmd.exe, which runs.cmdshims, rejects those as a working directory with "UNC paths are not supported".Changes
vtandvttwithwhich::which_in, the same wayvpresolves task programs. On Windows,whichskips files that aren't Windows binaries and tries thePATHEXTextensions, findingpnpm.cmd. On Unix it finds the same file as before.dunce::simplified, which drops the verbatim prefix when the path means the same without it.dunceis a new dev-dependency ofvt_bin.vtandvttkeep the working directory they had before.pnpmdirectly, and itspnpm-installtask is removed.🤖 Generated with Claude Code