Skip to content

fix: reuse active Vite+ installations for exact versions - #146

Merged
fengmk2 merged 8 commits into
mainfrom
test/reproduce-vp-reinstall-145
Sep 21, 2026
Merged

fengmk2 merged 8 commits into
mainfrom
test/reproduce-vp-reinstall-145

Conversation

@fengmk2

@fengmk2 fengmk2 commented Sep 10, 2026

Copy link
Copy Markdown
Member

The action reuses a complete active installation for an exact version (0.3.0 or later), avoiding repeated downloads on persistent runners. Fixes #145.

flowchart LR
    A["Same exact version already installed"] -->|Before this PR| B["Download and reinstall"]
    A -->|With this PR| C{"Reuse checks pass?"}
    C -->|Yes| D["Reuse existing files<br/>No CLI download"]
    C -->|No| B
    B --> E["Apply inputs and continue setup"]
    D --> E
    classDef reuse fill:#dafbe1,stroke:#1a7f37,color:#1f2328
    classDef install fill:#fff1e5,stroke:#bc4c00,color:#1f2328
    class D reuse
    class B install
Loading

For two setups of the same exact version, with a healthy retained installation and no management overrides:

Work Before this PR With this PR
Installer runs 2 1
CLI download during the second setup Repeated None
Active installation files during the second setup Reinstalled Unchanged

Reuse checks include the required native binding. Failed checks or environment overrides that require configuration changes use the installer. The action also adds fallback-bin to the end of PATH when present.

Tests cover reuse and binding repair on Linux, macOS, and Windows. Linux tests also cover restored installations and package-manager overrides. All 76 enabled CI jobs pass.

@fengmk2 fengmk2 changed the title test: reproduce repeated Vite+ installation (#145) fix: reuse active Vite+ installations for exact versions Sep 10, 2026
@fengmk2
fengmk2 force-pushed the test/reproduce-vp-reinstall-145 branch 2 times, most recently from a37d9f1 to 99960f1 Compare September 19, 2026 05:26
@fengmk2
fengmk2 marked this pull request as ready for review September 21, 2026 09:54
@fengmk2 fengmk2 added the run-e2e Request GitLab E2E for the reviewed fork PR commit (requires write access). label Sep 21, 2026
@github-actions

Copy link
Copy Markdown
Contributor

❌ GitLab E2E did not complete successfully

Commit: d24cc30cd3bc3cedf1016c02600c946b15edbd0b
Suite: full · Vite+ version: latest

GitLab pipeline · GitHub Actions run

@fengmk2
fengmk2 force-pushed the test/reproduce-vp-reinstall-145 branch from d24cc30 to 2d92377 Compare September 21, 2026 13:40
@fengmk2
fengmk2 merged commit ad4675d into main Sep 21, 2026
156 of 157 checks passed
@fengmk2
fengmk2 deleted the test/reproduce-vp-reinstall-145 branch September 21, 2026 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run-e2e Request GitLab E2E for the reviewed fork PR commit (requires write access).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Skip re-installing an already-installed Vite+ version: setup-vp and install.sh re-download on every job (~3s each)

1 participant