fix: reuse active Vite+ installations for exact versions - #146
Merged
Merged
Conversation
fengmk2
force-pushed
the
test/reproduce-vp-reinstall-145
branch
2 times, most recently
from
September 19, 2026 05:26
a37d9f1 to
99960f1
Compare
fengmk2
marked this pull request as ready for review
September 21, 2026 09:54
Contributor
❌ GitLab E2E did not complete successfullyCommit: |
fengmk2
force-pushed
the
test/reproduce-vp-reinstall-145
branch
from
September 21, 2026 13:40
d24cc30 to
2d92377
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The action reuses a complete active installation for an exact version (
0.3.0or later), avoiding repeated downloads on persistent runners. Fixes #145.flowchart LR A["Same exact version already installed"] -->|Before this PR| B["Download and reinstall"] A -->|With this PR| C{"Reuse checks pass?"} C -->|Yes| D["Reuse existing files<br/>No CLI download"] C -->|No| B B --> E["Apply inputs and continue setup"] D --> E classDef reuse fill:#dafbe1,stroke:#1a7f37,color:#1f2328 classDef install fill:#fff1e5,stroke:#bc4c00,color:#1f2328 class D reuse class B installFor two setups of the same exact version, with a healthy retained installation and no management overrides:
Reuse checks include the required native binding. Failed checks or environment overrides that require configuration changes use the installer. The action also adds
fallback-binto the end ofPATHwhen present.Tests cover reuse and binding repair on Linux, macOS, and Windows. Linux tests also cover restored installations and package-manager overrides. All 76 enabled CI jobs pass.