fix: preserve Vite+ generated PATH across CI steps - #171
Closed
liangmiQwQ wants to merge 2 commits into
Closed
liangmiQwQ wants to merge 2 commits into
liangmiQwQ wants to merge 2 commits into
Conversation
Member
|
I think it was fixed in #146 |
Collaborator
Author
That's correct, thanks for that! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vite+ PR voidzero-dev/vite-plus#2758 moves system-first shims into a fallback directory at the end of PATH. setup-vp currently propagates only the main bin directory, so commands such as
pnpmcan become unavailable after opting out of package-manager management when no system installation exists.This PR sources Vite+'s generated environment script and carries its PATH into the current process and later GitHub Actions, GitLab, and Azure steps. Only the main bin uses the runners' prepend APIs, preserving system-tool precedence over managed fallbacks. Older releases retain the existing bin-directory behavior when no generated PATH is available.
Regression coverage checks command resolution with and without system tools, mixed modes, and later PATH additions. The package-manager CI matrix now checks actual commands on Linux, macOS, and Windows.
🤖 Generated with Codex