Repository navigation
Conversation
mnoah1
added this pull request to stack #839
October 12, 2026 14:22
mnoah1
force-pushed
the
mnoah1/stovepipe-web-e2e
branch
from
October 12, 2026 14:51
95f5825 to
99bb189
Compare
mnoah1
force-pushed
the
mnoah1/stovepipe-web-e2e
branch
from
October 12, 2026 15:00
99bb189 to
2df95bd
Compare
mnoah1
force-pushed
the
mnoah1/stovepipe-web-e2e
branch
from
October 12, 2026 15:13
2df95bd to
9e37974
Compare
This was referenced Oct 12, 2026
mnoah1
removed this pull request from stack #839
October 12, 2026 15:29
mnoah1
added this pull request to stack #843
October 12, 2026 15:29
mnoah1
force-pushed
the
mnoah1/stovepipe-web-e2e
branch
from
October 12, 2026 15:44
9e37974 to
96605a6
Compare
mnoah1
marked this pull request as ready for review
October 12, 2026 15:50
mnoah1
requested review from
a team,
behinddwalls and
sbalabanov
as code owners
October 12, 2026 15:50
mnoah1
added a commit
that referenced
this pull request
Oct 12, 2026
Send web logs through per-request callbacks so hosts can use their own logging context. Keep Pino in the reference hosts, preserve original errors and structured fields, and isolate callback failures from page results. Builds on the web E2E layer in #838.
mnoah1
removed this pull request from stack #843
October 12, 2026 20:08
mnoah1
added this pull request to stack #847
October 12, 2026 20:08
mnoah1
marked this pull request as draft
October 12, 2026 22:05
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
The new Stovepipe UI needs browser coverage against a real backend, in addition to its unit and component tests. Align both services' browser suites under
web/test/e2e/<domain>so they follow the repository layout and reuse stack setup helpers.What?
web/test/e2e/submitqueue, preserving its browser spec and Compose overlay.web/test/e2e/stovepipewith real ingestion and seeded pagination data. Cover queue navigation and cursors, encoded change URIs, project pagination (including pages with no recorded results), raw project JSON containing only returned entries across all backend pages, history, refresh, empty queues, and accessibility.Test Plan
Latest validation passed all 31 targets in
//web:checkplus//web/test/e2e/stovepipe:web_test, including coverage that absent projects are omitted from the table and JSON export.All 33 targets passed on the rebased stack, including both real-stack browser suites and the pinned Compose checks:
./tool/bazel test //web:check //web/test/e2e/submitqueue:web_test //web/test/e2e/stovepipe:web_test //tool/compose:compose_test --test_output=errorsRepository formatting, lint, module tidy, and Gazelle checks also passed. Browser tests require a running Docker daemon; Bazel supplies Compose and the browser.
Revert Plan
Revert this PR to restore the previous SubmitQueue test location and remove the Stovepipe browser suite. The frontend and shared-package PRs can remain.
Issue Links
None — no issue was supplied for this work.
Stack
main).Merge in this order.