Repository navigation
Update the Selenium video recorder and Service Bus SQL Server images - #1600
Merged
Merged
Conversation
This was referenced Oct 13, 2026
cristianrgreco
marked this pull request as ready for review
October 13, 2026 15:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two modules start a second container from an image that is a string in their source. Dependabot only reads
Dockerfiles, so these were never bumped.SELENIUM_VIDEO_IMAGE(the recorder behindwithRecording())selenium/video:ffmpeg-4.3.1-20230508(May 2023, amd64 only)selenium/video:ffmpeg-8.1-20260909(amd64 and arm64)DEFAULT_MSSQL_IMAGE(the database the emulator needs)mcr.microsoft.com/mssql/server:2022-CU14-ubuntu-22.04mcr.microsoft.com/mssql/server:2022-CU27-ubuntu-22.04ffprobe, which the test (and the docs snippet taken from it) used to check the saved file, so the check now decodes the file withffmpeg -v error -i <file> -f null -.withMssqlContainer(), which the existing custom-container test covers.Core's own images were checked and left alone:
testcontainers/ryuk:0.14.0andtestcontainers/sshd:1.4.0are the latest tags. TheSocatContainerdefault,alpine/socat:1.7.4.3-r0, is behind (1.8.1.3 is out); that is a core default and not part of this PR.Verification
Local, macOS arm64, Docker Desktop:
npx vitest run packages/modules/selenium --maxConcurrency=2, new recorder image, oldffprobecheckexpected 127 to be +0(ffprobenot found), 4 passedffmpegcheckselenium/standalone-chrome:153.0andselenium/standalone-firefox:156.0(local edit, not committed; CI runs these on amd64)npx vitest run packages/modules/azureservicebus --maxConcurrency=1npm run format,npm run lint,npm run knip,npm run check-compiles: clean.seleniumVideoExampledocs marker still resolves.Left to CI: Podman, Node 22 and 24, linux/amd64, and the docs build.
Not breaking
No exports, signatures or options change. Users pull newer versions of the two helper images:
video.mp4and retrieved the same way. Anyone who runsffprobeinside the recorder image themselves will find it gone.withMssqlImage()andwithMssqlContainer()still override it.