Skip to content

Update the Selenium video recorder and Service Bus SQL Server images - #1600

Merged
cristianrgreco merged 2 commits into
mainfrom
claude/update-internal-module-images
Oct 13, 2026
Merged

cristianrgreco merged 2 commits into
mainfrom
claude/update-internal-module-images

Conversation

@cristianrgreco

@cristianrgreco cristianrgreco commented Oct 13, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Two modules start a second container from an image that is a string in their source. Dependabot only reads Dockerfiles, so these were never bumped.

Module Constant Before After
selenium SELENIUM_VIDEO_IMAGE (the recorder behind withRecording()) selenium/video:ffmpeg-4.3.1-20230508 (May 2023, amd64 only) selenium/video:ffmpeg-8.1-20260909 (amd64 and arm64)
azureservicebus DEFAULT_MSSQL_IMAGE (the database the emulator needs) mcr.microsoft.com/mssql/server:2022-CU14-ubuntu-22.04 mcr.microsoft.com/mssql/server:2022-CU27-ubuntu-22.04
  • Selenium: recording works unchanged with the new image. It no longer ships ffprobe, which the test (and the docs snippet taken from it) used to check the saved file, so the check now decodes the file with ffmpeg -v error -i <file> -f null -.
  • Service Bus: stays on SQL Server 2022 and moves to its latest cumulative update. The suite also passes with a 2025 container through withMssqlContainer(), which the existing custom-container test covers.

Core's own images were checked and left alone: testcontainers/ryuk:0.14.0 and testcontainers/sshd:1.4.0 are the latest tags. The SocatContainer default, alpine/socat:1.7.4.3-r0, is behind (1.8.1.3 is out); that is a core default and not part of this PR.

Verification

Local, macOS arm64, Docker Desktop:

Run Result
npx vitest run packages/modules/selenium --maxConcurrency=2, new recorder image, old ffprobe check 2 failed: expected 127 to be +0 (ffprobe not found), 4 passed
same, with the ffmpeg check 6 passed
same, with the browser images switched to selenium/standalone-chrome:153.0 and selenium/standalone-firefox:156.0 (local edit, not committed; CI runs these on amd64) 6 passed
npx vitest run packages/modules/azureservicebus --maxConcurrency=1 4 passed (SQL Server under amd64 emulation)
  • npm run format, npm run lint, npm run knip, npm run check-compiles: clean.
  • The seleniumVideoExample docs marker still resolves.

Left to CI: Podman, Node 22 and 24, linux/amd64, and the docs build.

Not breaking

No exports, signatures or options change. Users pull newer versions of the two helper images:

  • Recordings are still saved as video.mp4 and retrieved the same way. Anyone who runs ffprobe inside the recorder image themselves will find it gone.
  • The Service Bus default database stays on the same SQL Server major. withMssqlImage() and withMssqlContainer() still override it.

@cristianrgreco cristianrgreco added dependencies Pull requests that update a dependency file patch Backward compatible bug fix labels Oct 13, 2026
@cristianrgreco
cristianrgreco marked this pull request as ready for review October 13, 2026 15:51
@cristianrgreco
cristianrgreco merged commit f791d07 into main Oct 13, 2026
22 checks passed
@cristianrgreco
cristianrgreco deleted the claude/update-internal-module-images branch October 13, 2026 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file patch Backward compatible bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant