Skip to content

Feature/add bootstrap toggle - #549

Merged
dav-sonn merged 6 commits into
developfrom
feature/add-bootstrap-toggle
Oct 28, 2026
Merged

dav-sonn merged 6 commits into
developfrom
feature/add-bootstrap-toggle

Conversation

@andrewbaxter439

Copy link
Copy Markdown
Collaborator

What and WHY

This is a potential solution to #329

Tried a quick solution. This goes through the process of:

  • Setting bootstrapAll to false by default
  • At the start of the multirun main it overrides this to 'true'
  • It then looks in config file to see if this is changed/set
  • If then parses command line arguments to see if -bootstrap=false is flagged
  • If set to false either in config file or command line it flags up "WARNING: Bootstrapping is disabled. Enabling bootstrapping for multiruns is recommented [sic] for analytical runs."

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The integration-test configuration inherits the new bootstrap default without corresponding updates to its existing statistical baselines.

1 open issue
What changed in this PR

This PR addresses #329 by making regression-coefficient bootstrapping configurable and enabling it by default for multiruns to account for parameter uncertainty.

Changes:

  • Makes bootstrapAll mutable while retaining its default of false outside multirun startup.
  • Enables bootstrapping for multiruns, with YAML and command-line overrides.
  • Adds a warning when multirun bootstrapping is disabled.
File Description
src/​main/​java/​simpaths/​experiment/​SimPathsMultiRun.java Sets the multirun default, parses the bootstrap option, and warns when disabled.
src/​main/​java/​simpaths/​data/​Parameters.java Makes bootstrapAll configurable rather than constant.

Review effort: Balanced


multiRunMode = true;

Parameters.bootstrapAll = true;

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems a good suggestion! bootstrapping should be disabled in integration tests as a good practice - this should be fixed before merging.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added parameter_args.bootstrapAll: false to config/test_run.yml in commit abdee07 to preserve the integration-test baselines.

Co-authored-by: dav-sonn <62243276+dav-sonn@users.noreply.github.com>
Copilot AI requested a review from dav-sonn October 27, 2026 17:15
@dav-sonn
dav-sonn merged commit b7ea55a into develop Oct 28, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants