Repository navigation
Feature/add bootstrap toggle - #549
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The integration-test configuration inherits the new bootstrap default without corresponding updates to its existing statistical baselines.
1 open issue
What changed in this PR
This PR addresses #329 by making regression-coefficient bootstrapping configurable and enabling it by default for multiruns to account for parameter uncertainty.
Changes:
- Makes
bootstrapAllmutable while retaining its default offalseoutside multirun startup. - Enables bootstrapping for multiruns, with YAML and command-line overrides.
- Adds a warning when multirun bootstrapping is disabled.
| File | Description |
|---|---|
| src/main/java/simpaths/experiment/SimPathsMultiRun.java | Sets the multirun default, parses the bootstrap option, and warns when disabled. |
| src/main/java/simpaths/data/Parameters.java | Makes bootstrapAll configurable rather than constant. |
Review effort: Balanced
|
|
||
| multiRunMode = true; | ||
|
|
||
| Parameters.bootstrapAll = true; |
Collaborator
Author
There was a problem hiding this comment.
This seems a good suggestion! bootstrapping should be disabled in integration tests as a good practice - this should be fixed before merging.
There was a problem hiding this comment.
Added parameter_args.bootstrapAll: false to config/test_run.yml in commit abdee07 to preserve the integration-test baselines.
Co-authored-by: dav-sonn <62243276+dav-sonn@users.noreply.github.com>
dav-sonn
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What and WHY
This is a potential solution to #329
Tried a quick solution. This goes through the process of: