Repository navigation
Final clean-up: comments, dependencies, debug ios, register URLs, package contents (REV-144) - #78
Open
revopushbot wants to merge 2 commits into
Open
revopushbot wants to merge 2 commits into
revopushbot wants to merge 2 commits into
Conversation
… dead code Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…kage contents - Keep only "why" comments; move release and metrics helpers next to the code that uses them - One bundler runner: fails unless the bundler exits 0, reports spawn errors, ignores blank CODE_PUSH_NODE_ARGS - hermesc no longer gets CODE_PUSH_NODE_ARGS (copy-paste from the original code) - Replace backslash, email-validator, wordwrap, which and simctl with small local code that keeps their behaviour - Repair debug ios on current Xcode: read simulator logs with simctl log stream - register takes [apiServerUrl] [appServerUrl] like login - release-native removes its metadata zip when the release fails before uploading - Publish only bin/script; clean before build and pack - Tests use a private temp folder Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Last PR in the REV-132..145 clean-up series. It also includes #77's commit (a0cf51c), so #77 will be closed.
Changes
react-native bundleandexpo export:embed. A release now fails unless the bundler exits with 0, failing to start the bundler is reported as an error, and a blankCODE_PUSH_NODE_ARGSis ignored. The raw-args debug log was dropped.CODE_PUSH_NODE_ARGS. Those are Node options, copied by mistake in the original code.backslash,email-validator,wordwrap,whichandsimctlare replaced with small local code. The backslash and email rules match the old libraries exactly, and a repeated--descriptionno longer crashes.debug iosworks again on current Xcode: simulators no longer write asystem.logfile, so logs are read withxcrun simctl spawn <udid> log stream.registertakes[apiServerUrl] [appServerUrl], likelogin.release-nativeremoves its metadata zip when the release fails before uploading.bin/scriptis published (26 files / 48.7 kB instead of 108 / 152 kB). The build cleans first, andprepackbuilds.createZip.Verification
register.debug ioswas tested on a booted simulator, anddebug androidwas also checked.Old bugs found in the code review are tracked in REV-146 and are not part of this PR.
🤖 Generated with Claude Code