Repository navigation
Treat Ctrl+C at a y/N prompt as no; clean up temp zips safely; remove dead code - #77
Closed
revopushbot wants to merge 1 commit into
Closed
revopushbot wants to merge 1 commit into
revopushbot wants to merge 1 commit into
Conversation
… dead code Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the final clean-up (REV-144). These are small fixes that only change error paths, plus some dead code removal.
Fixes
ui/terminal.ts): it used to crash withTypeError: Cannot read properties of undefined (reading 'response'). Now it counts as "no", so the command prints its usual "… cancelled." message and exits 0. Only an actual Ctrl+C is handled this way. Any other prompt error still fails the command exactly as before, so a script can't mistake it for a cancel.management-sdk.ts): if the file was already gone,unlinkSyncthrew inside the superagent callback, giving an uncaughtENOENTand a release promise that never settled. It now usesrmSync({ force: true }), best effort, so the upload's result always comes back.management-sdk.ts): if zipping a release folder failed, a randomly named.zipwas left in the current folder. It's deleted now.Dead code
initiateExternalAuthenticationAsync(action, url)never usedactionand wasn't async. It's renamedopenLoginPage(url), andloginWithExternalAuthenticationloses the unusedactiontoo. The URLs are built exactly as before.types/rest-definitions.tsno longer re-exports itself.Verification
mainTypeErrorstack trace, exit 1test/terminal.tscovers y, an empty answer, Ctrl+C and other prompt errors.test/management-sdk.tscovers the partial zip being deleted and an upload whose zip is already gone. The three fix tests fail onmain.tsc, lint and format are clean.🤖 Generated with Claude Code