[Php80] Skip loose comparisons that differ from strict, keep variable needle

rules-tests/Php80/Rector/Identical/StrEndsWithRector/Fixture/fixture_equal.php.inc → rules-tests/Php80/Rector/Identical/StrEndsWithRector/Fixture/loose_substr.php.inc

@@ -2,7 +2,7 @@
 
 namespace Rector\Tests\Php80\Rector\Identical\StrEndsWithRector\Fixture;
 
-class Fixture
+class LooseSubstr
 {
     public function run()
     {
@@ -18,7 +18,7 @@ class Fixture
 
 namespace Rector\Tests\Php80\Rector\Identical\StrEndsWithRector\Fixture;
 
-class Fixture
+class LooseSubstr
 {
     public function run()
     {

rules-tests/Php80/Rector/Identical/StrEndsWithRector/Fixture/substr_not_equal_prefix.php.inc → rules-tests/Php80/Rector/Identical/StrEndsWithRector/Fixture/loose_substr_not_prefix.php.inc

@@ -2,7 +2,7 @@
 
 namespace Rector\Tests\Php80\Rector\Identical\StrEndsWithRector\Fixture;
 
-class SubstrNotPrefix
+class LooseSubstrNotPrefix
 {
     public function run()
     {
@@ -18,7 +18,7 @@ class SubstrNotPrefix
 
 namespace Rector\Tests\Php80\Rector\Identical\StrEndsWithRector\Fixture;
 
-class SubstrNotPrefix
+class LooseSubstrNotPrefix
 {
     public function run()
     {

rules-tests/Php80/Rector/Identical/StrEndsWithRector/Fixture/skip_loose_numeric_string.php.inc

@@ -0,0 +1,14 @@
+<?php
+
+namespace Rector\Tests\Php80\Rector\Identical\StrEndsWithRector\Fixture;
+
+class SkipLooseNumericString
+{
+    public function run($haystack)
+    {
+        // '+1' == '01' is true
+        $isMatch = substr($haystack, -2) == '01';
+    }
+}
+
+?>

rules-tests/Php80/Rector/Identical/StrStartsWithRector/Fixture/not_equal_substr.php.inc → rules-tests/Php80/Rector/Identical/StrStartsWithRector/Fixture/loose_not_equal_substr.php.inc

@@ -2,7 +2,7 @@
 
 namespace Rector\Tests\Php80\Rector\Identical\StrStartsWithRector\Fixture;
 
-class NotIdenticalSubstr
+class LooseNotEqualSubstr
 {
     public function run()
     {
@@ -16,7 +16,7 @@ class NotIdenticalSubstr
 
 namespace Rector\Tests\Php80\Rector\Identical\StrStartsWithRector\Fixture;
 
-class NotIdenticalSubstr
+class LooseNotEqualSubstr
 {
     public function run()
     {

rules-tests/Php80/Rector/Identical/StrStartsWithRector/Fixture/fixture_equal.php.inc → rules-tests/Php80/Rector/Identical/StrStartsWithRector/Fixture/loose_substr.php.inc

@@ -2,7 +2,7 @@
 
 namespace Rector\Tests\Php80\Rector\Identical\StrStartsWithRector\Fixture;
 
-class Fixture
+class LooseSubstr
 {
     public function run()
     {
@@ -16,7 +16,7 @@ class Fixture
 
 namespace Rector\Tests\Php80\Rector\Identical\StrStartsWithRector\Fixture;
 
-class Fixture
+class LooseSubstr
 {
     public function run()
     {

rules-tests/Php80/Rector/Identical/StrStartsWithRector/Fixture/other_side_equal.php.inc → rules-tests/Php80/Rector/Identical/StrStartsWithRector/Fixture/loose_substr_other_side.php.inc

@@ -2,7 +2,7 @@
 
 namespace Rector\Tests\Php80\Rector\Identical\StrStartsWithRector\Fixture;
 
-class OtherSide
+class LooseSubstrOtherSide
 {
     public function run()
     {
@@ -18,7 +18,7 @@ class OtherSide
 
 namespace Rector\Tests\Php80\Rector\Identical\StrStartsWithRector\Fixture;
 
-class OtherSide
+class LooseSubstrOtherSide
 {
     public function run()
     {

rules-tests/Php80/Rector/Identical/StrStartsWithRector/Fixture/skip_loose_numeric_string.php.inc

@@ -0,0 +1,14 @@
+<?php
+
+namespace Rector\Tests\Php80\Rector\Identical\StrStartsWithRector\Fixture;
+
+class SkipLooseNumericString
+{
+    public function run($haystack)
+    {
+        // '+1' == '01' is true
+        $isMatch = substr($haystack, 0, 2) == '01';
+    }
+}
+
+?>

rules-tests/Php80/Rector/Identical/StrStartsWithRector/Fixture/skip_loose_strpos.php.inc

@@ -0,0 +1,13 @@
+<?php
+
+namespace Rector\Tests\Php80\Rector\Identical\StrStartsWithRector\Fixture;
+
+class SkipLooseStrpos
+{
+    public function run()
+    {
+        $isMatch = strpos($haystack, $needle) == 0;
+    }
+}
+
+?>

rules-tests/Php80/Rector/Identical/StrStartsWithRector/Fixture/skip_loose_strpos_hardcoded.php.inc

@@ -0,0 +1,13 @@
+<?php
+
+namespace Rector\Tests\Php80\Rector\Identical\StrStartsWithRector\Fixture;
+
+class SkipLooseStrposHardcoded
+{
+    public function run()
+    {
+        $isMatch = strpos($haystack, 'hardcoded') == 0;
+    }
+}
+
+?>

rules-tests/Php80/Rector/Identical/StrStartsWithRector/Fixture/skip_loose_strpos_not_prefix.php.inc

@@ -0,0 +1,13 @@
+<?php
+
+namespace Rector\Tests\Php80\Rector\Identical\StrStartsWithRector\Fixture;
+
+class SkipLooseStrposNotPrefix
+{
+    public function run()
+    {
+        $notMatch = strpos($haystack, $needle) != 0;
+    }
+}
+
+?>

rules-tests/Php80/Rector/Identical/StrStartsWithRector/Fixture/skip_loose_strpos_other_side.php.inc

@@ -0,0 +1,13 @@
+<?php
+
+namespace Rector\Tests\Php80\Rector\Identical\StrStartsWithRector\Fixture;
+
+class SkipLooseStrposOtherSide
+{
+    public function run()
+    {
+        $isMatch = 0 == strpos($haystack, $needle);
+    }
+}
+
+?>

rules/Php80/MatchAndRefactor/StrStartsWithMatchAndRefactor/StrposMatchAndRefactor.php

@@ -30,7 +30,12 @@ public function __construct(
 
     public function match(Identical|NotIdentical|Equal|NotEqual $binaryOp): ?StrStartsWith
     {
-        $isPositive = $binaryOp instanceof Identical || $binaryOp instanceof Equal;
+        // strpos() returns false on no match, and false == 0
+        if ($binaryOp instanceof Equal || $binaryOp instanceof NotEqual) {
+            return null;
+        }
+
+        $isPositive = $binaryOp instanceof Identical;
 
         if ($binaryOp->left instanceof FuncCall && $this->nodeNameResolver->isName($binaryOp->left, 'strpos')) {
             return $this->processBinaryOpLeft($binaryOp, $isPositive);

rules/Php80/MatchAndRefactor/StrStartsWithMatchAndRefactor/SubstrMatchAndRefactor.php

@@ -5,6 +5,7 @@
 namespace Rector\Php80\MatchAndRefactor\StrStartsWithMatchAndRefactor;
 
 use PhpParser\Node;
+use PhpParser\Node\Expr;
 use PhpParser\Node\Expr\BinaryOp\Equal;
 use PhpParser\Node\Expr\BinaryOp\Identical;
 use PhpParser\Node\Expr\BinaryOp\NotEqual;
@@ -34,6 +35,10 @@ public function match(Identical|NotIdentical|Equal|NotEqual $binaryOp): ?StrStar
         $isPositive = $binaryOp instanceof Identical || $binaryOp instanceof Equal;
 
         if ($binaryOp->left instanceof FuncCall && $this->nodeNameResolver->isName($binaryOp->left, 'substr')) {
+            if (! $this->isRefactorableLooseComparison($binaryOp, $binaryOp->right)) {
+                return null;
+            }
+
             $funcCall = $binaryOp->left;
 
             $haystack = $funcCall->getArgs()[0]
@@ -43,6 +48,10 @@ public function match(Identical|NotIdentical|Equal|NotEqual $binaryOp): ?StrStar
         }
 
         if ($binaryOp->right instanceof FuncCall && $this->nodeNameResolver->isName($binaryOp->right, 'substr')) {
+            if (! $this->isRefactorableLooseComparison($binaryOp, $binaryOp->left)) {
+                return null;
+            }
+
             $funcCall = $binaryOp->right;
 
             $haystack = $funcCall->getArgs()[0]
@@ -127,4 +136,19 @@ private function isHardcodedStringWithLNumberLength(StrStartsWith $strStartsWith
 
         return $lNumberLength->value === strlen($expr->value);
     }
+
+    /**
+     * Loose comparison of two numeric string literals is numeric, e.g. '+1' == '01';
+     * skip only that case, a variable needle is kept
+     */
+    private function isRefactorableLooseComparison(
+        Identical|NotIdentical|Equal|NotEqual $binaryOp,
+        Expr $comparedExpr
+    ): bool {
+        if (! $binaryOp instanceof Equal && ! $binaryOp instanceof NotEqual) {
+            return true;
+        }
+
+        return !$comparedExpr instanceof String_ || !is_numeric($comparedExpr->value);
+    }
 }

rules/Php80/Rector/Identical/StrEndsWithRector.php

@@ -142,6 +142,10 @@ private function refactorSubstr(BinaryOp $binaryOp): FuncCall|BooleanNot|null
             return null;
         }
 
+        if (! $this->isRefactorableLooseComparison($binaryOp, $comparedNeedleExpr)) {
+            return null;
+        }
+
         if (count($substrFuncCall->getArgs()) < 2) {
             return null;
         }
@@ -252,6 +256,19 @@ private function isHardCodedLNumberAndString(Expr $substrOffset, Expr $needle):
         return $lNumber->value === strlen($needle->value);
     }
 
+    /**
+     * Loose comparison of two numeric string literals is numeric, e.g. '+1' == '01';
+     * skip only that case, a variable needle is kept
+     */
+    private function isRefactorableLooseComparison(BinaryOp $binaryOp, Expr $comparedExpr): bool
+    {
+        if (! $binaryOp instanceof Equal && ! $binaryOp instanceof NotEqual) {
+            return true;
+        }
+
+        return !$comparedExpr instanceof String_ || !is_numeric($comparedExpr->value);
+    }
+
     private function buildReturnNode(Expr $haystack, Expr $needle, bool $isPositive): FuncCall|BooleanNot
     {
         $funcCall = $this->nodeFactory->createFuncCall('str_ends_with', [$haystack, $needle]);