Repository navigation
[Php80] Skip loose comparisons that differ from strict, keep variable needle - #8645
Closed
TomasVotruba wants to merge 3 commits into
Closed
TomasVotruba wants to merge 3 commits into
TomasVotruba wants to merge 3 commits into
Conversation
…thRector and StrEndsWithRector
Member
Author
|
Cherry picked from: #8643 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #8643. Same goal: loose
==/!=comparisons that don't behave likestr_starts_with()/str_ends_with()must not be refactored. This variant keeps more real-world cases.Difference from #8643: a
substr(...) == \$needlewith a non-literal (variable) needle is still refactored. The numeric-string gotcha only triggers when both operands are numeric string literals ('+1' == '01'), so the skip is narrowed to that single case.Change:
strpos() == 0/!= 0: skipped -strpos()returnsfalseandfalse == 0substr(...) == '01'/!=: skipped only when the needle is a numeric string literalsubstr(...) == \$needle(variable needle): still refactoredstrncmp()/substr_compare()loose comparisons: unchanged, they always return an intOpened to verify CI against the kept-variable-needle behavior.