Repository navigation
[Php80] Skip loose comparisons that differ from strict on StrStartsWithRector and StrEndsWithRector - #8643
Closed
guillaume-sainthillier wants to merge 1 commit into
Conversation
…thRector and StrEndsWithRector
| $isMatch = substr($haystack, -strlen($needle)) == $needle; | ||
|
|
||
| $isMatch = $needle == substr($haystack, -strlen($needle)); | ||
| } |
Member
There was a problem hiding this comment.
Can you revert this? While technically it's correct removal, in legacy projects where this change would be valid most people use ==.
Contributor
Author
|
Closing, as it follows the same loose-comparison reasoning that was declined in #8641. Thanks! |
guillaume-sainthillier
deleted the
strstartswith-skip-loose-comparison
branch
October 12, 2026 11:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some loose comparisons handled since #3246 don't behave like
str_starts_with()/str_ends_with():Change:
strpos() == 0/!= 0: skippedsubstr(...) == $needle/!=: only refactored when the needle is a non-numeric string literal, where==behaves like===strncmp()/substr_compare()loose comparisons: unchanged, they always return an intFollow-up to #8641, which does the same for
StrContainsRector/MbStrContainsRector.