Repository navigation
Explain DeltaSignal's result columns in the panel - #765
Closed
adamjohnwright wants to merge 1 commit into
Closed
adamjohnwright wants to merge 1 commit into
adamjohnwright wants to merge 1 commit into
Conversation
A curator could not tell what Influence, or the other columns, meant. The table's headers now say what each number is (activity × normal, change vs baseline), and a short "What do these columns mean?" note, opened in place, defines each column in plain words from DeltaSignal's own API documentation, and says how the rows are sorted and grouped. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Replaced by the next PR, which corrects the Influence definition. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A curator testing DeltaSignal on beta couldn't tell what the result table's Influence column meant, nor quite what the others meant.
The change
Clearer headers: Entity, Activity (× normal), Change vs baseline, Influence. The headers also get
role="columnheader", to go with the table's existing roles.A short note above the table, "What do these columns mean?". It opens in place, so it works on touch screens, where tooltips don't. It defines:
node_activities × 100, per DeltaSignal's docs/API.md.)Σ|∂F/∂input|at the solution, per docs/API.md andcompute_influence_scores.)The note also says that rows are sorted by the size of the change, that a highlighted row is one the user perturbed, and that an entity made of several logic nodes shows their average activity and change and their largest influence (
aggregateRowsByReactomeId).Text and style only. The pre-push checks passed: types, lint, unit tests, builds and an end-to-end smoke run.
🤖 Generated with Claude Code