Skip to content

Deprecate currentBridge API and drop its last internal uses #59428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
christophpurrer wants to merge 2 commits into from
+5 −24
Closed

Deprecate currentBridge API and drop its last internal uses #59428

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df8156c
Prune dead RCTBridge private declarations and stubs (#59427)
christophpurrer Oct 23, 2026
32c2732
Deprecate currentBridge API and drop its last internal uses
christophpurrer Oct 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 5 additions & 10 deletions packages/react-native/React/Base/RCTBridge+Private.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
#import <React/RCTBridge.h>

@class RCTModuleRegistry;
@protocol RCTJavaScriptExecutor;

#if !defined(RCT_REMOVE_LEGACY_MODULE_INTEROP) || !defined(RCT_REMOVE_LEGACY_COMPONENT_INTEROP)
RCT_EXTERN NSArray<Class> *RCTGetModuleClasses(void);
Expand All @@ -17,8 +16,9 @@ RCT_EXTERN void RCTRegisterModule(Class);

@interface RCTBridge ()

+ (instancetype)currentBridge;
+ (void)setCurrentBridge:(RCTBridge *)bridge;
+ (instancetype)currentBridge __deprecated_msg("This API will be removed along with the legacy architecture.");
+ (void)setCurrentBridge:(RCTBridge *)bridge
__deprecated_msg("This API will be removed along with the legacy architecture.");

/**
* This method is used to invoke a callback that was registered in the
Expand All @@ -36,19 +36,14 @@ RCT_EXTERN void RCTRegisterModule(Class);
/**
* An object that allows one to require NativeModules/TurboModules.
* RCTModuleRegistry is implemented in bridgeless mode and bridge mode.
* Used by RCTRootView.
*/
@property (nonatomic, strong, readonly) RCTModuleRegistry *moduleRegistry;
@property (nonatomic, strong, readonly) RCTModuleRegistry *moduleRegistry __deprecated_msg(
"Access RCTModuleRegistry directly instead; this property will be removed.");

@end

@interface RCTBridge (RCTCxxBridge)

/**
* Called on the child bridge to run the executor and start loading.
*/
- (void)start;

/**
* Dispatch work to a module's queue - this is also supports the fake RCTJSThread
* queue. Exposed for the RCTProfiler
Expand Down
4 changes: 0 additions & 4 deletions packages/react-native/React/Base/RCTBridge.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,10 +323,6 @@ - (BOOL)isBatchActive
return NO;
}

- (void)setUp
{
}

- (void)enqueueCallback:(NSNumber *)cbID args:(NSArray *)args
{
}
Expand Down
8 changes: 0 additions & 8 deletions packages/react-native/React/Base/RCTBridgeProxy.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,14 +296,6 @@ - (BOOL)moduleSetupComplete
return YES;
}

- (void)start
{
[self
logError:
@"Starting the bridge proxy does nothing. If you want to start React Native, please use RCTHost start. Nooping"
cmd:_cmd];
}

- (void)registerAdditionalModuleClasses:(NSArray<Class> *)newModules
{
[self
Expand Down
2 changes: 0 additions & 2 deletions packages/react-native/ReactCommon/react/runtime/platform/ios/ReactCommon/RCTInstance.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
#import <React/NSDataBigString.h>
#import <React/RCTAssert.h>
#import <React/RCTBridge+Inspector.h>
#import <React/RCTBridge+Private.h>
#import <React/RCTBridge.h>
#import <React/RCTBridgeModule.h>
#import <React/RCTBridgeModuleDecorator.h>
Expand Down Expand Up @@ -329,7 +328,6 @@ - (void)_start
bridgeProxy.jsCallInvoker = jsCallInvoker;
bridgeProxy.performanceLogger = _performanceLogger;
_bridgeProxy = bridgeProxy;
[RCTBridge setCurrentBridge:(RCTBridge *)bridgeProxy];

// Set up TurboModules
_turboModuleManager = [[RCTTurboModuleManager alloc] initWithBridgeProxy:bridgeProxy
Expand Down
Loading