Repository navigation
Deprecate currentBridge API and drop its last internal uses - #59428
Open
christophpurrer wants to merge 2 commits into
Open
christophpurrer wants to merge 2 commits into
christophpurrer wants to merge 2 commits into
Conversation
Summary: Remove the zero-caller `start` declaration, the dangling `RCTJavaScriptExecutor` forward declaration, and the orphaned `setUp`/`start` stubs left behind by the private-header pruning. Keep `moduleRegistry`, which Expo's `AppContext` still reads, and mark it deprecated. No behavior change. Changelog: [Internal] ___ landed-with-radar-review Differential Revision: D127228439
Summary: `+[RCTBridge currentBridge]` always returns nil and `setCurrentBridge:` is a no-op, so remove the two `RCTInstance` call sites and their now-dead private-header imports. Keep the declarations for Expo's Swift `RCTBridge.current()` caller and mark them deprecated. Changelog: [Internal] Differential Revision: D127265579
meta-cla
Bot
added
the
CLA Signed
|
@christophpurrer has exported this pull request. If you are a Meta employee, you can view the originating Diff in D127265579. |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 23, 2026
) Summary: `+[RCTBridge currentBridge]` always returns nil and `setCurrentBridge:` is a no-op, so remove the two `RCTInstance` call sites and their now-dead private-header imports. Keep the declarations for Expo's Swift `RCTBridge.current()` caller and mark them deprecated. Changelog: [Internal] Differential Revision: D127265579
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 24, 2026
) Summary: `+[RCTBridge currentBridge]` always returns nil and `+[RCTBridge setCurrentBridge:]` is a no-op: with the legacy bridge gone, nothing ever sets a current bridge, so the getter can only return nil. Remove the last two internal call sites in `RCTInstance` (iOS and macOS) along with their now-dead `RCTBridge+Private.h` imports. Keep both declarations, now marked deprecated, so existing external Swift callers (`RCTBridge.current()`) keep compiling and linking; they will only ever observe nil, the sole value this API can produce. Changelog: [Internal] Differential Revision: D127265579
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 24, 2026
) Summary: `+[RCTBridge currentBridge]` always returns nil and `+[RCTBridge setCurrentBridge:]` is a no-op: with the legacy bridge gone, nothing ever sets a current bridge, so the getter can only return nil. Remove the last two internal call sites in `RCTInstance` (iOS and macOS) along with their now-dead `RCTBridge+Private.h` imports. Keep both declarations, now marked deprecated, so existing external Swift callers (`RCTBridge.current()`) keep compiling and linking; they will only ever observe nil, the sole value this API can produce. Changelog: [Internal] Differential Revision: D127265579
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 24, 2026
) Summary: Pull Request resolved: react#59428 `+[RCTBridge currentBridge]` always returns nil and `+[RCTBridge setCurrentBridge:]` is a no-op: with the legacy bridge gone, nothing ever sets a current bridge, so the getter can only return nil. Remove the last two internal call sites in `RCTInstance` (iOS and macOS) along with their now-dead `RCTBridge+Private.h` imports. Keep both declarations, now marked deprecated, so existing external Swift callers (`RCTBridge.current()`) keep compiling and linking; they will only ever observe nil, the sole value this API can produce. Changelog: [Internal] Differential Revision: D127265579
Visual regression2 visual difference(s) at android: no capture ios
|
| Expected | Captured |
|---|---|
 |
 |
ios touchable/highlight/default: Changed, 42 px (0.039%)
Expected and Captured
| Expected | Captured |
|---|---|
 |
 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
+[RCTBridge currentBridge]always returns nil andsetCurrentBridge:is a no-op, so remove the twoRCTInstancecall sites and their now-dead private-header imports. Keep the declarations for Expo's SwiftRCTBridge.current()caller and mark them deprecated.Changelog: [Internal]
Differential Revision: D127265579