Repository navigation
fix(wiki): restore direct publication without submodules - #366
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Summary
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Linked Issues check |  |
Issue #365 has coding requirements. The PR adds wiki-direct.yml with read-only PR generation and main-only publication through a separate Wiki checkout. The publisher preserves manual pages, repla… |
| Out of Scope Changes check | |
The workflow changes, packaged callers, sync change, tests, documentation, changelog, generated output, and Wiki submodule metadata removal directly support issue #365. The release guard and retry upd… |
| Docstring Coverage | |
Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. (6 skipped: 6 … |
| Title check | |
The title clearly identifies the main change: restoring direct Wiki publication without submodules. |
| Description check | |
The description includes all required sections and provides detailed context, changes, verification results, documentation updates, changelog entry, and reviewer notes. |
✨ Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
I’m a rabbit with pages to share,
I hop through the Markdown with care.
Pull requests make an artifact bright,
Main sends the pages to the Wiki at night.
Local sync leaves submodules behind,
And carrots of code are easy to find!
Comment @coderabbitai help to get the list of available commands.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a286666dfc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
🚀 Preview is available for this pull request. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c44339acd9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
@codex review |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
github-project-automation
Bot
moved this from Backlog
to Released
in PHP Fast Forward Project
1 participant
Related Issue
Closes #365
Motivation / Context
Nine consumer Wiki workflows fail before execution because their old entry point no longer supports workflow_call. Use the direct publication model verified in php-fast-forward/container#15, with one shared implementation instead of copying it into every library.
Changes
Verification
Full composer dev-tools passed: 717 tests, 2,201 assertions, 91.83% line coverage; Rector, PHPDoc, ECS and documentation generation passed.
Focused SyncCommand regression failed before the change and passes after it (3 tests / 21 assertions).
Real Markdown generation from this checkout passed without a Wiki submodule.
Actual publisher Bash passed 54 offline assertions with disposable Git repositories, including manual preservation, stale API pruning, no-op, stale SHA rejection and unsafe-payload rejection. No remote Wiki was modified by these tests.
Composer validation, changelog check and diff check passed. Actionlint passed with only its obsolete schema warning for GitHub's supported concurrency.queue key excluded; the same queue:max setting is already exercised by container's successful workflow.
Follow-up: 24 focused checks passed for release gitlink detection, dispatch independence and isolated-generation selection. GitHub validates the revised renderer on the current commit.
No-API follow-up: 48 checks executed the actual generation shell and canonical resolver for no-autoload, missing directories, files-only and API-bearing fixtures. An API fixture with a missing Home.md still fails; no empty payload is published.
Documentation / Generated Output
README, wiki/sync command docs, workflow guide, architecture and AGENTS updated. Generated Markdown and docs were inspected.
Changelog
Added two Changed entries for direct publication and submodule-free sync.
Reviewer Notes
Consumer PRs will reference an exact commit of this workflow so their read-only generation can be tested before this PR merges. Merge the shared workflow before consumer adoption to keep normal DevTools synchronization aligned. Existing workflow targets need explicit migration or sync --overwrite.
Publication remains to be verified on each consumer after merge. Main can advance after the final source check but before the Wiki push; the queued newer publication catches up. The two repositories do not share an atomic write.
The full local gate reports pre-existing PHPmetrics warnings from malformed JUnit XML; PHPUnit itself reports zero warnings/risky tests. No unrelated metrics repair is included.