Skip to content

fix(wiki): restore publication without a submodule - #4

Open
coisa wants to merge 1 commit into
mainfrom
codex/wiki-without-submodule
Open

coisa wants to merge 1 commit into
mainfrom
codex/wiki-without-submodule

Conversation

@coisa

@coisa coisa commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

The current Wiki workflow fails before executing any jobs: its old entry point no longer supports workflow_call. Adopt the direct-publication workflow derived from php-fast-forward/container#15 and shared in php-fast-forward/dev-tools#366.

Generate API Markdown with read-only credentials on PRs; only main can publish through an isolated checkout of the separate Wiki repository. Remove the .github/wiki gitlink and its matching .gitmodules entry, preserving the remote Wiki/history. Allow the GrumPHP shim installed by current DevTools; other Composer constraints and allowlist entries remain unchanged.

The caller is pinned to a286666dfca2300fffca1ab0d3517b6294ec2c4e, the reviewed implementation commit of dev-tools#366. This makes the generation checks executable before that shared PR merges; merge the shared change first so normal dev-tools:sync also stops invoking wiki --init.

Validation: Composer validate --strict --no-plugins, actionlint and git diff --check passed. The shared actual publisher passed 54 offline assertions and DevTools passed 717 tests / 2,201 assertions with 91.83% coverage. GitHub checks exercise this repository's real Markdown generation. Publication is main-only and remains to be verified after merge.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-13T07:30:11.059940Z 54b47d0 PR opened
🔒 Security Review ✅ Completed 2026-10-13T07:37:28.465126Z 54b47d0 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: f1058f73-787b-4c3e-95a7-189928d34f98
📥 Commits

Reviewing files that changed from the base of the PR and between 60b70e9 and 54b47d0.

📒 Files selected for processing (4)
  • .github/wiki
  • .github/workflows/wiki.yml
  • .gitmodules
  • composer.json
💤 Files with no reviewable changes (2)
  • .github/wiki
  • .gitmodules

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Summary

Summary by CodeRabbit

  • Chores
    • Updated wiki publishing automation to run on pushes to the main branch, pull requests, and manual requests.
    • Adjusted the automation’s publishing permissions and workflow configuration.
    • Removed the wiki repository integration and allowed an additional Composer plugin. These configuration changes do not alter app features.

The wiki workflow adds pull-request triggers, reduces its permissions, and calls a pinned reusable workflow. The wiki submodule configuration is removed. Composer now allows the phpro/grumphp-shim plugin.

Changes: Wiki workflow

Layer / File(s) Summary
Wiki workflow and submodule configuration
.github/workflows/wiki.yml, .github/wiki, .gitmodules
The workflow runs on pushes to main, pull requests, and manual dispatches. It calls wiki-direct.yml at a pinned commit, requests only contents: write, and removes secrets: inherit. The .github/wiki submodule reference and its .gitmodules entry are removed.

Composer plugin configuration

Layer / File(s) Summary
Allow Composer plugin
composer.json
The Composer plugin allowlist adds phpro/grumphp-shim.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 54b47

Pull requests generate Wiki content without write access, while publication is limited to main. The publisher’s token path has successfully pushed to a Wiki remote, and no remaining submodule dependency was found; no actionable merge-blocking issue is established.

Pre-merge checks · Passed 5
Passed Passed checks (5 passed)
Check name Status Explanation
Title check Passed The title clearly identifies the main change: restoring Wiki publication without the submodule.
Description check Passed The description directly explains the workflow replacement, submodule removal, publication permissions, pinned caller, Composer change, and validation results.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the workflow gate,
Pull requests now join the queue.
A pinned wiki path waits in place,
The plugin list admits one more.
Then I hop home beneath the moon.

Comment @coderabbitai help to get the list of available commands.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant