Repository navigation
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 17 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep pose-graph vertex indices local to the graph being loaded.
PGVertexpreviously used a class-wide counter that every loader reset. Interleaving a second load could leave the first graph with indices such as[0, 3]for two vertices, breaking optimisation matrix indexing and lidar lookups.Pass each graph's current vertex count when constructing its pose or landmark vertices instead of sharing a counter. Add deterministic interleaving regressions for g2o and TORO, sequential controls, optimisation equivalence, and lidar lookup with and without landmarks. Public
PoseGrapharguments and file formats are unchanged.Related issue
Addresses the graph-local vertex-counter item in #746. Other checklist items remain open; this is independent of #769.
Validation
Linux, Python 3.12.14:
main(2de1e3e), the new tests give 4 failures and 2 passing controls; with the fix, 6 pass.python -m pytest tests/ --ignore=tests/test_blocks.py --timeout=50 --timeout_method=thread -q: 998 passed, 12 skipped, 66 subtests passed. Both native extensions were built and verified available; collision dependencies were available. The run reports 14 existing deprecation warnings.git diff --checkpass.PoseGraph.pyare unchanged (module naming, imports, dictionary style, and an unused local). This is not a claim of repository-wide lint cleanliness or of passing the upstream platform/Python CI matrix.Checklist