Skip to content

test(app-shell): move the objectui#12393 grid pins out of plugin-list so its type-check stops compiling plugin-grid (objectui#12422) #12435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
objectstack-fleet merged 2 commits into from
Oct 15, 2026
Merged

test(app-shell): move the objectui#12393 grid pins out of plugin-list so its type-check stops compiling plugin-grid (objectui#12422) #12435

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7010215
test(app-shell): move the objectui#12393 grid pins out of plugin-list…
claude Oct 15, 2026
513ddc4
test(app-shell): name the 12376 sibling pin's package now that the fi…
claude Oct 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .changeset/12422-cross-package-pin.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
---

Test-only: the objectui#12393 grouped-grid and `$select` family pins move from `@object-ui/plugin-list` to `@object-ui/app-shell`, which declares both packages, so `plugin-list`'s type-check no longer compiles `plugin-grid` source across a package boundary; no published file changes.
20 changes: 12 additions & 8 deletions ...istView.gridRowColorSelect-12393.test.tsx → ...istView.gridRowColorSelect-12393.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,16 @@
/**
* objectui#12393 — the grid half of objectui#12376, and the family pin.
*
* `ListView.rowColorSelect-12376.test.tsx` pins `ListView`'s own `$select`
* plugin-list's `ListView.rowColorSelect-12376.test.tsx` pins `ListView`'s own `$select`
* asking for a non-column `rowColor.field`. That projection does not reach
* every row the list draws: a GROUPED grid over a data source that answers the
* group header query owns its fetch (`gridOwnsGroupedFetch`), and its rows
* arrive through `ObjectGrid`'s own `$select`, which had no row-colour arm. So
* a grouped list tinted by a field no column shows painted nothing.
*
* Both blocks below take the same two steps, because plugin-list's tests run
* without the grid registered (`vitest.setup.dom-light.tsx`):
* Both blocks below take the same two steps, with a stub `object-grid`
* registered over whatever the registry holds (the `@object-ui/plugin-grid`
* import registers the real one; `afterAll` puts it back):
* 1. mount `ListView` with a stub `object-grid` and keep the node it hands
* the grid, and the `$select` of its own window fetch;
* 2. render the real `ObjectGrid` with that node, and read the `$select` of
Expand Down Expand Up @@ -72,11 +73,14 @@ vi.mock('@object-ui/permissions', async (importOriginal) => {
import { ComponentRegistry } from '@object-ui/core';
import { SchemaRendererProvider, ActionProvider } from '@object-ui/react';
import { registerAllFields } from '@object-ui/fields';
import { ListView } from '../ListView';
// The real grid, by path: plugin-list declares no dependency on plugin-grid
// (it renders the grid through the registry), and this file needs the
// component itself.
import { ObjectGrid } from '../../../plugin-grid/src/ObjectGrid';
// Both components by package name. This file lives in app-shell because
// app-shell declares both packages; plugin-list declares no dependency on
// plugin-grid (it renders the grid through the registry). It used to sit in
// plugin-list and reach the grid by a relative path, so plugin-list's
// type-check compiled `ObjectGrid` and its `@object-ui/plugin-detail` import
// without any declared edge ordering that build first (objectui#12422).
import { ListView } from '@object-ui/plugin-list';
import { ObjectGrid } from '@object-ui/plugin-grid';

const OBJECT = 'crm_case';

Expand Down
Loading