Skip to content

test(app-shell): carry the current flow clone notice in the PackagedAutomationPage fixture - #28300

Merged
objectstack-fleet[bot] merged 1 commit into
mainfrom
claude/issue-28073-clone-notice-fixture
Oct 31, 2026
Merged

objectstack-fleet[bot] merged 1 commit into
mainfrom
claude/issue-28073-clone-notice-fixture

Conversation

@objectstack-fleet

@objectstack-fleet objectstack-fleet Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

domain:ui#5 · os-sales · session_01L6bhgUhKx1XHzkoikGjRB4

Requested by Sales · project thread

Fixes #28073

Clause-②: no
Metadata-protocol: none

维护者速读

  • 改了什么:PackagedAutomationPage.test.tsx 里的 CLONE_NOTICE 夹具换成服务端 FLOW_CLONE_NOTICE 的当前单行文案。
  • 为什么改:fix(runtime): say the flow clone notice in one business line #28072 已把服务端提示改成一句话,夹具仍是旧的七句话,测试读到的不是服务端实际发送的内容。
  • 风险与回滚:仅测试夹具,不发布、不影响运行时;回滚即还原这一个字符串。
  • 先看:ui/packages/app-shell/src/views/setup/PackagedAutomationPage.test.tsx 约 L100-103,唯一的 hunk。
  • 两分钟验证:在 ui/ 目录执行 pnpm exec vitest run packages/app-shell/src/views/setup/PackagedAutomationPage.test.tsx,预期 31 个测试全绿。
  • 需要你做的:无,席位落地。

What changes

The CLONE_NOTICE fixture now carries exactly the text of FLOW_CLONE_NOTICE in packages/runtime/src/flow-clone.ts (one line). It stays a literal copy: @object-ui/app-shell does not depend on @objectstack/runtime, and a test-only import would add a new dependency edge.

Tests

  • pnpm exec vitest run packages/app-shell/src/views/setup/PackagedAutomationPage.test.tsx from ui/: 1 file, 31 tests passed.
  • node scripts/check-sdui-manifest.mjs: exit 0.

Acceptance notes

Test-only change in a private package; no changeset (skip-changeset declared at pr_create).

Verification

Derived gate commands run from the worktree; see the card report for exit codes.


Generated by Claude Code

🤖 Generated with Claude Code

https://claude.ai/code/session_01L6bhgUhKx1XHzkoikGjRB4

…utomationPage fixture

Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01L6bhgUhKx1XHzkoikGjRB4
@objectstack-fleet objectstack-fleet Bot added the skip-changeset PR has no user-facing published change; bypasses the changeset gate label Oct 31, 2026
@objectstack-fleet

Copy link
Copy Markdown
Contributor Author

domain:ui#5 · os-sales · session_01L6bhgUhKx1XHzkoikGjRB4

ACCEPT · 2026-10-31T04:11Z
Head-sha: 5c7c893

席位核对

  1. Shape: one file, ui/packages/app-shell/src/views/setup/PackagedAutomationPage.test.tsx, +2 / −4, inside the claimed surface (claim 6538281520). Fixes #28073 on the first card line; no other card number sits next to a closing keyword. Not governed and under 3000 lines (check-governed-merges --pr 28300: NOT governed, 6 changed lines). skip-changeset: private package, test-only diff, read by the seat.
  2. Premise, measured: the new fixture string is character-for-character the FLOW_CLONE_NOTICE value in packages/runtime/src/flow-clone.ts (≈L189-191) on origin/main 69ce01d7. The literal copy is kept because @object-ui/app-shell has no dependency on @objectstack/runtime; accepted.
  3. Gates (check-runs on this head): 64 runs, 45 success, 19 skipped, 0 other. Lint · repo & tooling gates, Type Check · workspace and all 16 Test UI shards are success. The skips are the path-filtered core jobs, opt-in harnesses, Check Changeset / Check PR Size under skip-changeset, and Auto Label; none touches ui/.
  4. Deviations accepted: the dev's local vitest run scripts/ (ui) and two repo-wide scans did not finish clean in a fresh worktree (NOT MEASURED locally); CI's shards on this head are the reading of record.
  5. Out of scope: none. Skills-docs: not owed (Metadata-protocol: none).
  6. Landing: ordinary seat landing: pr_ready + automerge_enable through the relay, then MERGED is confirmed and the card is closed out.

Generated by Claude Code

@objectstack-fleet
objectstack-fleet Bot marked this pull request as ready for review October 31, 2026 04:13
@objectstack-fleet
objectstack-fleet Bot enabled auto-merge October 31, 2026 04:13
@objectstack-fleet
objectstack-fleet Bot added this pull request to the merge queue Oct 31, 2026
Merged via the queue into main with commit de2a2e4 Oct 31, 2026
65 checks passed
@objectstack-fleet
objectstack-fleet Bot deleted the claude/issue-28073-clone-notice-fixture branch October 31, 2026 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xs skip-changeset PR has no user-facing published change; bypasses the changeset gate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ui: the PackagedAutomationPage test fixture still carries the old seven-sentence flow clone notice after #27886

1 participant