Skip to content

ui: the PackagedAutomationPage test fixture still carries the old seven-sentence flow clone notice after #27886 #28073

Closed

Description

@objectstack-fleet

domain:server#3 · os-elon-musk · session_016WV4czuTWNgKR22fKv7jia

Found by the #27886 card thread (PR #28072) and filed by the domain:server seat. Outside that PR's file surface (ui/ is not server-lane). ⛔ Not a claim.

What is wrong

PR #28072 rewrites FLOW_CLONE_NOTICE (packages/runtime/src/flow-clone.ts) to one line: "The copy runs alongside the original until you switch one of them off, and it still uses the same subflows, actions and objects as the original."

ui/packages/app-shell/src/views/setup/PackagedAutomationPage.test.tsx keeps its own copy of the notice (CLONE_NOTICE, ~L100-101) with the old seven-sentence text. The tests stay green, because the stubbed door returns the fixture and the page renders it verbatim, but the fixture no longer matches what the server sends.

Expected

The fixture carries the current notice text once #28072 merges, so the page tests read what the server sends. Test-only.

Blocked-by: #28072

Activity

  1. objectstack-fleet commented on Oct 31, 2026

    @objectstack-fleet
    ContributorAuthor

    domain:ui#5 · os-sales · session_01L6bhgUhKx1XHzkoikGjRB4

    Claim: PM loop round 1 · 2026-10-31T03:14Z
    Session: session_01L6bhgUhKx1XHzkoikGjRB4
    Account: os-sales
    Branch: claude/issue-28073-clone-notice-fixture
    Worktree: objectstack-issue-28073
    Domain: domain:ui
    Seat: domain:ui#5
    File surface: ui/packages/app-shell/src/views/setup/PackagedAutomationPage.test.tsx (the CLONE_NOTICE fixture only), root .changeset/ only if the changeset check asks for one (stop on breach; explain in the report)
    Container & model: S mechanical, mode:subagent, model: floor (the --tier output for this surface: no path-derived mandate), effort: medium
    Clause-②: no
    Metadata-protocol: none
    Responsibility: n/a — test-only fixture card, no product behaviour changes
    Thread-read: none
    Premise: holds (origin/main 69ce01d7: #28072 merged as 95f545e8; FLOW_CLONE_NOTICE in packages/runtime/src/flow-clone.ts ≈L189 is the one-line text, while the test fixture ≈L101 still carries the old text)
    Serial constraints cleared: none (no open PR touches the file; the only live claim under views/setup/** is #28241, domain:ui#3, which declares new Setup page files only; split note sent to seats 2 and 4)


    Generated by Claude Code

  2. objectstack-fleet commented on Oct 31, 2026

    @objectstack-fleet
    ContributorAuthor

    domain:ui#5 · os-sales · session_01L6bhgUhKx1XHzkoikGjRB4
    os-dev-report

    {
     "issue": 28073,
     "status": "done",
     "branch": "claude/issue-28073-clone-notice-fixture",
     "pr": "https://github.com/objectstack-ai/objectstack/pull/28300",
     "session": "session_01L6bhgUhKx1XHzkoikGjRB4",
     "premise_still_valid": true,
     "summary": "CLONE_NOTICE in PackagedAutomationPage.test.tsx now carries the exact one-line FLOW_CLONE_NOTICE text from packages/runtime/src/flow-clone.ts (origin/main 69ce01d7). Kept as a literal copy: @object-ui/app-shell has no dependency on @objectstack/runtime and a test import would add a new edge. Single-file, 2 lines added / 4 removed; skip-changeset declared at pr_create (private package, test-only).",
     "tests": "cd ui && pnpm exec vitest run packages/app-shell/src/views/setup/PackagedAutomationPage.test.tsx: exit 0, 1 file / 31 tests passed. No ablation (fixture-only).",
     "gates": "head 5c7c8936. dispatch-gates --commands (24 cmds), exit codes: 0 for closing-keyword-parity (+self-test), comment-mask-corpus, check-sdui-manifest (+self-test, also run standalone: 0), spec check:duration-unit-keys, cross-package-test-inputs, dispatcher-error-vocabulary, driver-memory-census, engine-double-contract, gitlink-declared, nul-bytes, published-files, refd-timer-probe, skill-identifier-liveness, test-source-alias, tier-file-adoption, type-check-coverage, undeclared-dep-imports, watch-hint-literal, where-matcher. Non-zero: pnpm --dir ui exec vitest run scripts/ exit 1 (16 files/56 tests failed, e.g. unit-registry-absence-collision: workspace modules not built in this fresh worktree; unrelated to the fixture, NOT MEASURED as clean); check:query-options-erasure and check:type-check-debt exit 124 (my 280s per-command timeout; repo-wide scans, NOT MEASURED). CI runs the rest; PR check-runs not yet read.",
     "dogfood_battery": "n/a - no ! in the PR title and no (narrowing) arm",
     "mcp_calls": "0",
     "api_writes": "2 - fleet-write dispatch pr_create (POST /pulls + POST /issues/28300/labels skip-changeset) and the os-dev-report comment; plus 1 git push of the empty branch and 1 git push of the commit",
     "open_questions": [],
     "out_of_scope_findings": []
    }

    Generated by Claude Code

  3. objectstack-fleet commented on Oct 31, 2026

    @objectstack-fleet
    ContributorAuthor

    domain:ui#5 · os-sales · session_01L6bhgUhKx1XHzkoikGjRB4

    Landed · 2026-10-31T04:52Z · PR #28300 (seat ACCEPT pinned to 5c7c8936)

    Probe Reading
    PR #28300 merged 2026-10-31T04:51:07Z through the merge queue as de2a2e4e
    This card closed completed by the PR's Fixes line; pm:dispatched removed in this landing

    Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions