Skip to content

Add billing phone verification inputs - #304

Draft
oschwald wants to merge 2 commits into
mainfrom
greg/billing-phone-verification-inputs
Draft

oschwald wants to merge 2 commits into
mainfrom
greg/billing-phone-verification-inputs

Conversation

@oschwald

@oschwald oschwald commented Oct 9, 2026

Copy link
Copy Markdown
Member

Adds phone_verification_method (:delivered_code, :network, :other), phone_was_verification_successful, and phone_verification_time to Minfraud::Components::Billing. They describe the most recent verification of the billing phone number.
The first commit fixes boolean encoding: request components now send true and false as JSON booleans and no longer drop false. This changes the wire format of /credit_card/was_3d_secure_successful and boolean custom inputs, which sent true as the string "true", and sends false for /order/is_gift, /order/has_gift_message, and /payment/was_authorized, which were omitted before.
Reviewer question: the fix checks the value's type instead of a list of boolean keys, so it also changes boolean custom inputs. Is that wanted, or should it apply only to the known boolean fields?

🤖 Generated with Claude Code

oschwald and others added 2 commits October 9, 2026 20:45
Request components dropped every false value and sent most booleans
as strings. Only was_authorized, is_gift, and has_gift_message kept
true as a JSON boolean, so was_3d_secure_successful and boolean custom
inputs went out as "true". Keep any true or false value as a JSON
boolean and drop only nil values.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Add the phone_verification_method, phone_was_verification_successful,
and phone_verification_time attributes to Billing. They describe the
most recent verification of the billing phone number. The method must
be :delivered_code, :network, or :other. With validation on, the
result must be a boolean and the time must be an RFC 3339 date-time.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 9, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant