Repository navigation
Conversation
Request components dropped every false value and sent most booleans as strings. Only was_authorized, is_gift, and has_gift_message kept true as a JSON boolean, so was_3d_secure_successful and boolean custom inputs went out as "true". Keep any true or false value as a JSON boolean and drop only nil values. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Add the phone_verification_method, phone_was_verification_successful, and phone_verification_time attributes to Billing. They describe the most recent verification of the billing phone number. The method must be :delivered_code, :network, or :other. With validation on, the result must be a boolean and the time must be an RFC 3339 date-time. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
phone_verification_method(:delivered_code,:network,:other),phone_was_verification_successful, andphone_verification_timetoMinfraud::Components::Billing. They describe the most recent verification of the billing phone number.The first commit fixes boolean encoding: request components now send
trueandfalseas JSON booleans and no longer dropfalse. This changes the wire format of/credit_card/was_3d_secure_successfuland boolean custom inputs, which senttrueas the string"true", and sendsfalsefor/order/is_gift,/order/has_gift_message, and/payment/was_authorized, which were omitted before.Reviewer question: the fix checks the value's type instead of a list of boolean keys, so it also changes boolean custom inputs. Is that wanted, or should it apply only to the known boolean fields?
🤖 Generated with Claude Code