Repository navigation
Conversation
mathiasrw
marked this pull request as draft
October 23, 2026 13:10
mathiasrw
marked this pull request as ready for review
October 23, 2026 13:11
mathiasrw
added this pull request to stack #842
October 23, 2026 13:57
mathiasrw
marked this pull request as draft
October 23, 2026 14:14
mathiasrw
marked this pull request as ready for review
October 23, 2026 14:20
mathiasrw
force-pushed
the
fix/822
branch
3 times, most recently
from
October 23, 2026 15:54
af7e975 to
8ae75e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #822
Stacked on #827.
Change
--jscode can throw anything, not only an error. The message is now made in a way that can not fail:throw Object.create(null)an object was thrownthrow {code: 42}[object Object]an object was thrown: {"code":42}throw ""an empty string was thrownthrow new Error("x")Error: xTests
test/fix/822.test.jsis new, and 3 of its 4 tests fail without the fix.yarn test-cipasses.From the review of 23 October.
After the review of 24 October
messagecan not be read is told by its name, likea TypeError was thrown.After the review of 24 October
Closes #845
a Foo was thrown: {"a":1}. Before the last fix it lost the class, and after it, what it held.�. That covers a long class name too.an Error was thrown,an Item was thrown.