Repository navigation
Conversation
mathiasrw
marked this pull request as draft
October 23, 2026 13:05
mathiasrw
marked this pull request as ready for review
October 23, 2026 13:13
mathiasrw
marked this pull request as draft
October 23, 2026 14:14
mathiasrw
marked this pull request as ready for review
October 23, 2026 14:22
mathiasrw
marked this pull request as draft
October 23, 2026 14:53
mathiasrw
marked this pull request as ready for review
October 23, 2026 14:57
mathiasrw
marked this pull request as draft
October 23, 2026 15:23
…nd never crash on it
…by what they give
mathiasrw
marked this pull request as ready for review
October 23, 2026 15:50
mathiasrw
force-pushed
the
fix/822
branch
4 times, most recently
from
October 23, 2026 15:55
8ae75e8 to
f509676
Compare
mathiasrw
marked this pull request as draft
October 23, 2026 15:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #824
Stacked on #828.
Change
Since #808,
--jscode that fails only gives the message. With--verboseit now also tells where, when that is in a file of the user, like a module loaded withr():nope()) has no such place, so nothing more is told.Tests
test/fix/824.test.jsis new.yarn test-cipasses.From the review of 23 October.
After the review of 24 October
try, so a thrown value whose getters throw no longer crashes the run with--verbose. Before, it undid Better error handling of --js code for none error throws to close #822 #828 for that flag.a (copy)/helper.js, is read as a whole.node:internal/…) and of code run withevalare not shown as fake../../paths. Paths innode_modulesare skipped too.new URL("x"),nope()and a Proxy that throws.After the review of 24 October
Closes #846
at /dir/a (copy)/top.js:1:11, is read first as that form, as the place comes right afterat. Before,/dir/a (was read as the name of a function, and the place was not told. A line with a name has its place in parentheses at the end, and is read as that form.Follow-up
stackPlaces()is nowstackTraceLocations(), andstackPlace()isuserCodeLocation().