Skip to content

fix(studio): finish native dark-control readability in signal and firmware workflow #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
masarray wants to merge 4 commits into from
Closed

fix(studio): finish native dark-control readability in signal and firmware workflow #196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9dddb29
fix(studio): use shared legible dark controls in Main.qml
masarray Oct 16, 2026
c26535a
fix(studio): use shared legible dark controls in SignalMatrix.qml
masarray Oct 16, 2026
870f0eb
fix(studio): use shared legible dark controls in QualityEditor.qml
masarray Oct 16, 2026
fe5608f
fix(studio): use shared legible dark controls in FirmwarePanel.qml
masarray Oct 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 3 additions & 33 deletions apps/arstack_studio/qml/FirmwarePanel.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,38 +41,6 @@ SurfacePanel {
}
}

component DarkComboBox: ComboBox {
id: combo
implicitHeight: 40
font.family: panel.uiFont
font.pixelSize: 11
leftPadding: 12
rightPadding: 34
contentItem: Text {
leftPadding: 2
rightPadding: 2
text: combo.displayText
color: combo.enabled ? panel.theme.text : panel.theme.muted2
font: combo.font
verticalAlignment: Text.AlignVCenter
elide: Text.ElideRight
}
indicator: Label {
x: combo.width - width - 12
y: (combo.height - height) / 2
text: "⌄"
color: combo.enabled ? panel.theme.textSoft : panel.theme.muted2
font.family: panel.uiFont
font.pixelSize: 13
}
background: Rectangle {
radius: 7
color: combo.hovered ? panel.theme.raisedHover : panel.theme.surface2
border.width: 1
border.color: combo.activeFocus ? panel.theme.accent : panel.theme.line
}
}

Component.onCompleted: if (panel.session) panel.session.requestRefreshPorts()

ColumnLayout {
Expand Down Expand Up @@ -219,7 +187,9 @@ SurfacePanel {
RowLayout {
Layout.fillWidth: true
spacing: 8
DarkComboBox {
StudioDarkComboBox {
theme: panel.theme
uiFont: panel.uiFont
id: firmwarePort
Layout.preferredWidth: 205
model: panel.device.ports
Expand Down
4 changes: 3 additions & 1 deletion apps/arstack_studio/qml/Main.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -789,7 +789,9 @@ ApplicationWindow {
CalmButton { theme: studioTheme; uiFont: root.uiFont; text: "50"; implicitWidth: 44; onClicked: root.setFrequencyValue(50) }
CalmButton { theme: studioTheme; uiFont: root.uiFont; text: "60"; implicitWidth: 44; onClicked: root.setFrequencyValue(60) }
Rectangle { width: 1; height: 24; color: studioTheme.lineSoft }
CheckBox {
StudioDarkCheckBox {
theme: studioTheme
uiFont: root.uiFont
enabled: root.signalFrequency > 0
checked: root.phaseLink
text: "3-phase link"
Expand Down
4 changes: 3 additions & 1 deletion apps/arstack_studio/qml/QualityEditor.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,9 @@ RowLayout {
}
}

ComboBox {
StudioDarkComboBox {
theme: editor.theme
uiFont: editor.uiFont
id: presetBox
implicitWidth: editor.compact ? 98 : 108
model: ["Good", "Invalid", "Questionable", "Test"]
Expand Down
4 changes: 3 additions & 1 deletion apps/arstack_studio/qml/SignalMatrix.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,9 @@ Rectangle {
anchors.rightMargin: 9
spacing: 6

CheckBox {
StudioDarkCheckBox {
theme: matrix.theme
uiFont: matrix.uiFont
Layout.preferredWidth: 25
Layout.alignment: Qt.AlignVCenter
checked: signalRow.channelEnabled
Expand Down
Loading