Skip to content

fix(studio): finish native dark-control readability in signal and firmware workflow - #196

Closed
masarray wants to merge 4 commits into
mainfrom
fix/studio-remaining-dark-controls-20261016
Closed

masarray wants to merge 4 commits into
mainfrom
fix/studio-remaining-dark-controls-20261016

Conversation

@masarray

Copy link
Copy Markdown
Owner

Root cause

PRs #192–#194 delivered the shared StudioDarkComboBox and StudioDarkCheckBox but left native Qt controls in the visible main signal workflow, Quality preset, and firmware serial port picker. Firmware used a second locally styled ComboBox with a Windows-native popup, creating inconsistent Windows dark contrast.

Scope

  • Main: use shared themed checkbox for 3-phase link.
  • SignalMatrix: use shared themed checkbox for per-channel enabled (same checked handler, no change to signal or device setpoint behavior).
  • QualityEditor: use shared dark dropdown for Good / Invalid / Questionable / Test; preserve values/current-index/apply handler.
  • Firmware: replace local DarkComboBox copy with the already-shared dark dropdown; preserve COM port model, refresh and firmware operation.
  • Remove the now-unused local firmware dark ComboBox to maintain one styling source.

Boundaries

Qt/QML presentation only; no C++ session/controller, serial transport, firmware, SV, PTP or emitted smpSynch changes. Existing 4I+4V user flow remains intact. Exact base: main@bcbebc32.

Verification

@masarray
masarray marked this pull request as ready for review October 16, 2026 10:55
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-16T10:58:25.994717Z fe5608f Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copy link
Copy Markdown
Owner Author

Superseded by the single integration PR #195, combined head 69cae271d044b32c03cc12fceac9257c0bf75f96. All four dark-control QML changes from this PR were consolidated atomically into #195 alongside its independent SignalMatrix menu/tooltip changes. This avoids two separate main merges, duplicate integration installers, and unnecessary repeated CI. Previously green Qt and lifecycle checks were for the separate head; use #195 exact combined-head CI as the final release gate. No firmware/PTP/sampling modifications.

@masarray masarray closed this Oct 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant