You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(studio): finish native dark-control readability in signal and firmware workflow - #196
PRs #192–#194 delivered the shared StudioDarkComboBox and StudioDarkCheckBox but left native Qt controls in the visible main signal workflow, Quality preset, and firmware serial port picker. Firmware used a second locally styled ComboBox with a Windows-native popup, creating inconsistent Windows dark contrast.
Scope
Main: use shared themed checkbox for 3-phase link.
SignalMatrix: use shared themed checkbox for per-channel enabled (same checked handler, no change to signal or device setpoint behavior).
QualityEditor: use shared dark dropdown for Good / Invalid / Questionable / Test; preserve values/current-index/apply handler.
Firmware: replace local DarkComboBox copy with the already-shared dark dropdown; preserve COM port model, refresh and firmware operation.
Remove the now-unused local firmware dark ComboBox to maintain one styling source.
Boundaries
Qt/QML presentation only; no C++ session/controller, serial transport, firmware, SV, PTP or emitted smpSynch changes. Existing 4I+4V user flow remains intact. Exact base: main@bcbebc32.
Verification
Confirmed all four changes in branch and compare reports exactly four QML files.
Pending: exact-head Qt QML compile/headless launch, Windows installer preview and visual Windows screenshot check. Do not merge solely on static changes.
Superseded by the single integration PR #195, combined head 69cae271d044b32c03cc12fceac9257c0bf75f96. All four dark-control QML changes from this PR were consolidated atomically into #195 alongside its independent SignalMatrix menu/tooltip changes. This avoids two separate main merges, duplicate integration installers, and unnecessary repeated CI. Previously green Qt and lifecycle checks were for the separate head; use #195 exact combined-head CI as the final release gate. No firmware/PTP/sampling modifications.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
PRs #192–#194 delivered the shared
StudioDarkComboBoxandStudioDarkCheckBoxbut left native Qt controls in the visible main signal workflow, Quality preset, and firmware serial port picker. Firmware used a second locally styled ComboBox with a Windows-native popup, creating inconsistent Windows dark contrast.Scope
DarkComboBoxcopy with the already-shared dark dropdown; preserve COM port model, refresh and firmware operation.Boundaries
Qt/QML presentation only; no C++ session/controller, serial transport, firmware, SV, PTP or emitted
smpSynchchanges. Existing 4I+4V user flow remains intact. Exact base:main@bcbebc32.Verification