Repository navigation
Conversation
Node.js 22.12+ can require() ES modules, so the separate CommonJS build is no longer needed. Drop it and the dual package hazard that came with it.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node.js 22.12+ (and 20.19+) can
require()ES modules without a flag, so the separate CommonJS build is no longer needed."type": "module"and build once withtsc(module: nodenext) intodist/modulefield and therequire/importconditions inexportsengines.nodeto>=22.12importfirstThis also removes the dual package hazard (two copies of
Parserwhen both formats get loaded) and the types mismatch where the ESM entry used CJS typings.Verified locally:
npm run build,npm test(166 passed), and bothrequire("binary-parser")andimport { Parser } from "binary-parser"resolveParseron Node.Since
enginesis raised, this should be released as a major version.