Repository navigation
Fix examples for ESM - #309
Merged
Merged
Conversation
Import the library with its .ts extension and use import.meta.dirname instead of __dirname so that the examples can be run directly with node example/<name>.ts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #308,
node example/<name>.tsfails withERR_MODULE_NOT_FOUNDbecause the extensionless import of../lib/binary_parsercan no longer be resolved, and__dirnameis undefined in ES modules.../lib/binary_parser.tsimport.meta.dirnameinstead of__dirnameAll examples now run with
node example/<name>.ts(Node.js 22.18+ for type stripping).