Repository navigation
chore: Use dapr 1.19.0-rc.2 - #1833
Conversation
Run the integration tests against Dapr runtime 1.19.0-rc.2, the same change dapr#1820 made for rc.1: the runtime version in validate.yml, the proto download URL in pom.xml, and the Testcontainers image version. DAPR_CLI_VER stays at 1.18.0 until a CLI release candidate exists. The rc.2 protos only add fields (conversation max_tokens, metadata on actor reminder and timer callbacks), so no SDK code changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017JhKUDV9dbs5JDz2uwZqz5 Signed-off-by: Nelson Parente <nelson_parente@live.com.pt>
There was a problem hiding this comment.
🟢 Approval recommended
The version updates are consistent, and the referenced Dapr rc.2 release exists.
0 open findings
What changed in this PR
Updates Java SDK integration testing and generated Dapr protos to Dapr Runtime 1.19.0-rc.2.
Changes:
- Updates the Dapr proto source to rc.2.
- Updates CI and Testcontainers runtime images to rc.2.
- Retains Dapr CLI 1.18.0.
| File | Description |
|---|---|
pom.xml |
Uses rc.2 Dapr protos. |
.github/workflows/validate.yml |
Runs validation against rc.2. |
testcontainers-dapr/src/main/java/io/dapr/testcontainers/DaprContainerConstants.java |
Uses rc.2 container images. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1833 +/- ##
=========================================
Coverage 79.66% 79.66%
Complexity 2683 2683
=========================================
Files 267 267
Lines 7923 7923
Branches 839 839
=========================================
Hits 6312 6312
Misses 1252 1252
Partials 359 359 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Run the integration tests against Dapr runtime 1.19.0-rc.2, the same change #1820 made for rc.1: the runtime version in validate.yml, the proto download URL in pom.xml, and the Testcontainers image version. DAPR_CLI_VER stays at 1.18.0 until a CLI release candidate exists. The rc.2 protos only add fields (conversation max_tokens, metadata on actor reminder and timer callbacks), so no SDK code changes. Claude-Session: https://claude.ai/code/session_017JhKUDV9dbs5JDz2uwZqz5 (cherry picked from commit 0de95aa) Signed-off-by: Nelson Parente <nelson_parente@live.com.pt> Co-authored-by: Nelson Parente <nelson_parente@live.com.pt> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
|
@holopin-bot @nelson-parente sdk-badge Thank you! Here's a digital badge as a small token of appreciation. |
|
Congratulations @nelson-parente, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/cmvao5td70005lf04598ilzmd This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
Description
Runs the integration tests against Dapr runtime 1.19.0-rc.2, the same change #1820 made for rc.1:
DAPR_RUNTIME_VERinvalidate.ymldapr.proto.baseurlinpom.xml, nowv1.19.0-rc.2DAPR_VERSIONinDaprContainerConstants, the Testcontainers image versionDAPR_CLI_VERstays at 1.18.0, because no CLI release candidate exists yet.Compared with rc.1, the rc.2 protos only add fields:
max_tokenson conversation requests, andmetadataon actor reminder and timer callbacks. No SDK code changes.The 1.19.0-rc-2 SDK release needs this change on
release-1.19, so it needs thebackport release-1.19label.Issue reference
None.
Checklist
🤖 Generated with Claude Code
https://claude.ai/code/session_017JhKUDV9dbs5JDz2uwZqz5