Repository navigation
chore: Use dapr 1.19.0-rc.3 - #1850
Merged
Merged
Conversation
- validate.yml: run the integration tests against Dapr runtime 1.19.0-rc.3. - pom.xml: download the protos from v1.19.0-rc.3. - sdk-autogen/pom.xml: download runtime/v1/binarystore.proto. In 1.19.0-rc.3, dapr.proto imports this new file, so protoc fails without it. - DaprContainerConstants: use the 1.19.0-rc.3 image by default. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Nelson Parente <nelson_parente@live.com.pt>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Version pins are consistent, the required proto download is included, and static review identified no blocking issues.
0 open findings
What changed in this PR
Updates integration testing and generated protocol bindings to Dapr 1.19.0-rc.3, continuing the rc.2 update from #1833.
Changes:
- Aligns runtime, Testcontainers, and proto-source versions to rc.3.
- Downloads
binarystore.prototo satisfy the new upstream import without adding SDK APIs. - Leaves the CLI at rc.1.
| File | Description |
|---|---|
| testcontainers-dapr/src/main/java/io/dapr/testcontainers/DaprContainerConstants.java | Updates Testcontainers images to rc.3. |
| sdk-autogen/pom.xml | Adds the required binary-store proto download. |
| pom.xml | Points proto downloads to rc.3. |
| .github/workflows/validate.yml | Runs integration tests against runtime rc.3. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
javier-aliaga
approved these changes
Oct 16, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1850 +/- ##
============================================
+ Coverage 79.69% 79.73% +0.03%
- Complexity 2687 2693 +6
============================================
Files 267 268 +1
Lines 7933 7948 +15
Branches 842 844 +2
============================================
+ Hits 6322 6337 +15
Misses 1255 1255
Partials 356 356 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
5 tasks
javier-aliaga
pushed a commit
that referenced
this pull request
Oct 16, 2026
- validate.yml: run the integration tests against Dapr runtime 1.19.0-rc.3. - pom.xml: download the protos from v1.19.0-rc.3. - sdk-autogen/pom.xml: download runtime/v1/binarystore.proto. In 1.19.0-rc.3, dapr.proto imports this new file, so protoc fails without it. - DaprContainerConstants: use the 1.19.0-rc.3 image by default. (cherry picked from commit 410b0bb) Signed-off-by: Nelson Parente <nelson_parente@live.com.pt> Co-authored-by: Nelson Parente <nelson_parente@live.com.pt> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Runs the integration tests against Dapr runtime 1.19.0-rc.3. This is the same change that #1833 made for rc.2:
DAPR_RUNTIME_VERinvalidate.ymldapr.proto.baseurlinpom.xml, nowv1.19.0-rc.3DAPR_VERSIONinDaprContainerConstants, the Testcontainers image versionIt also adds
runtime/v1/binarystore.prototo the proto downloads insdk-autogen/pom.xml. The binary store API is new in rc.3, anddapr.protoimports this file. Without it, protoc fails:The SDK gets the generated binary store types (
DaprBinaryStoreProtos) and the new stub methods. This PR adds no SDK API for them.DAPR_CLI_VERstays at1.19.0-rc.1, the newest CLI release candidate.release-1.19has the same rc.2 pins, so this PR has thebackport release-1.19label.Issue reference
None.
Checklist
mvn -pl sdk-autogen,sdk -am install -DskipTestspasses with JDK 17. The same build without thebinarystore.protodownload fails with the error above.🤖 Generated with Claude Code