Skip to content

feat: Supporting arbitrary signature parameters #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dadrus merged 2 commits into from
Oct 17, 2026
Merged

feat: Supporting arbitrary signature parameters #156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
104dbb0
feat: Supporting arbitrary signature parameters
dadrus Oct 17, 2026
84335ac
linter warning resolved
dadrus Oct 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion signature_parameters.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ func (p *signatureParameters) fromInnerList(list httpsfv.InnerList) error {

p.tag = value
default:
return fmt.Errorf("%w: %s is unknown", ErrMalformedSignatureParameter, name)
// ignoring unknown parameter
}
}

Expand Down
12 changes: 7 additions & 5 deletions signature_parameters_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,7 +399,7 @@ func TestSignatureParametersFromInnerList(t *testing.T) {
},
},
{
uc: "failing parsing unknown parameter",
uc: "preserving unknown signature parameter",
list: httpsfv.InnerList{
Params: func() *httpsfv.Params {
params := httpsfv.NewParams()
Expand All @@ -408,12 +408,14 @@ func TestSignatureParametersFromInnerList(t *testing.T) {
return params
}(),
},
assert: func(t *testing.T, err error, _ *signatureParameters) {
assert: func(t *testing.T, err error, params *signatureParameters) {
t.Helper()

require.Error(t, err)
require.ErrorIs(t, err, ErrMalformedSignatureParameter)
require.ErrorContains(t, err, "foo is unknown")
require.NoError(t, err)

value, ok := params.Params.Get("foo")
require.True(t, ok)
assert.Equal(t, 1, value)
},
},
{
Expand Down
Loading