Repository navigation
feat: Supporting arbitrary signature parameters - #156
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #156 +/- ##
==========================================
- Coverage 94.48% 94.47% -0.01%
==========================================
Files 18 18
Lines 1323 1322 -1
==========================================
- Hits 1250 1249 -1
Misses 37 37
Partials 36 36 ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HTTP Message Signatures is designed to be profiled. Profiles such as WIMSE and Web Bot Auth introduce additional requirements, including potentially new signature parameters beyond those defined by RFC 9421.
This PR changes the parsing of signature parameters to accept and preserve unknown parameters instead of rejecting them. As before this change, only the parameters defined by RFC 9421 are interpreted and validated by the library.