Repository navigation
Numerator, Denominator and NumeratorDenominator keep extra operands when they canonicalize - #443
Closed
enumeratio wants to merge 3 commits into
Closed
enumeratio wants to merge 3 commits into
enumeratio wants to merge 3 commits into
Conversation
…rtcut only for a one-operand call, so extra operands survive canonicalization. Fix #ISSUE
# Conflicts: # CHANGELOG.md
Member
|
Thank you, this is landed on main in f601dee (commit, not merge, so the PR is closed rather than merged). It ships in the next release. Two additions beyond the PR:
Fixes #442. |
enumeratio
added a commit
to enumeratio/enumeratio
that referenced
this pull request
Oct 21, 2026
…cessary (BL-183) (#1031) Numerator/Denominator keep their extra operands through canonicalization since compute-engine 0.159 (cortex-js/compute-engine#443), so the `canonical` override that rebuilt the call through private `ce._fn` is gone. Still ours: the `tuples` broadcast exemption (the trailing `Over -> R` rule is a Tuple; 0.159's native `surplus-operands` alone still lets it thread). It is now set through `extendHead` (new `broadcastExemptions` field on `HeadPatch`) rather than by mutating the definition. Numerator stays in the provenance OVERRIDDEN list: compute-engine ignores `Over`, ours reads the ring. No example rows or `expected` values change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #442.
The quotient shortcut in their
canonicalhandlers now applies only to a one-operand call, soNumerator(a/b, x)stays a call instead of becominga.Numerator(a/b)is unchanged.