Repository navigation
Refuse a call with a surplus tuple operand whole, and type it without the broadcast lift - #468
Open
enumeratio wants to merge 1 commit into
Open
enumeratio wants to merge 1 commit into
enumeratio wants to merge 1 commit into
Conversation
…and its type is no longer lifted over a surplus list or tuple. Fix cortex-js#467
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #467.
hasSurplusOperands(the'surplus-operands'broadcast exemption) now applies to the component-wise tuple broadcast (tupleBroadcastCells) and to the result-type lift of a broadcastable operator, as it already did to the list broadcast arms. Heads that do not opt in, such as a chainedEqual, are unchanged.Numerator(3/2, (1, 2)): before,Tuple(Error, Error); after, oneunexpected-argumenterror, as for a surplus list.Numerator(3/2, (1, 2)): before,tuple<nothing | number, nothing | number>; after,nothing | number.Numerator(3/2, [1, 2]): before,list<nothing | number^2>; after,nothing | number, as forNumerator(3/2, Rule(Over, R)).Found while following up on #443.