Skip to content

feat(mosaic): add Waitlist - #10501

Open
kylemac wants to merge 3 commits into
mainfrom
kylemac/mosaic-waitlist-swingset
Open

kylemac wants to merge 3 commits into
mainfrom
kylemac/mosaic-waitlist-swingset

Conversation

@kylemac

@kylemac kylemac commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

TLDR for humans

  • Adds a mosaic 2.0 <Waitlist /> component
  • Adds it to swingset as mocked ui as well as live sandbox but live sandbox isn't fully functional unless you update the sandbox instance to be in waitlist mode.
CleanShot 2026-10-28 at 5 46 22 PM@2x

Description for robots

Adds <Waitlist /> to @clerk/mosaic: a card that adds an email address to the application's waitlist and thanks the user, taking afterJoinWaitlistUrl and signInUrl like the existing component and prefilling from an email_address query parameter. It follows the model → controller → view split, with a feature test against faked FAPI (a POST /v1/waitlist handler is added to the fake). Swingset gets a docs page under Misc and a live sandbox page at /live/misc/waitlist, which warns when the instance isn't in waitlist mode. The application logo in the header and the modal variant are not included, since Mosaic has neither an app logo component nor a waitlist modal surface yet.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Adds a connected <Waitlist /> to @clerk/mosaic, split into model, controller and view, with a feature test against faked FAPI. Wires it into swingset with a docs page and a live sandbox page.
@vercel

vercel Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
clerk-js-sandbox Ready Ready Preview Oct 29, 2026 12:01am UTC
swingset Ready Ready Preview Oct 29, 2026 12:01am UTC

Request Review

@changeset-bot

changeset-bot Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 469562f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@clerk/mosaic Minor
@clerk/swingset Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitai Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 86e1706 and 469562f.

Files selected for processing: 5
  • .changeset/mosaic-waitlist-review-fixes.md
  • packages/mosaic/src/features/waitlist/waitlist.controller.ts
  • packages/mosaic/src/features/waitlist/waitlist.model.ts
  • packages/swingset/src/app/(clerk)/live/live-overview.tsx
  • packages/swingset/src/app/(clerk)/live/misc/waitlist/page.tsx
Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 1 remain after this review.

Walkthrough

Adds the public Mosaic Waitlist component. It supports email prefilling from the query string, sign-in URL selection, and an optional redirect two seconds after a successful join. The change also adds localization, a fake API endpoint and feature tests, plus a Swingset live page, stories, and documentation.

Priority: Normal

Estimated code review effort: 3 (Moderate) | ~25 minutes

Possibly related PRs

Merge Risk: Minimal · up to 46956

No actionable merge-blocking issue was found in the waitlist changes.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 9.09% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Description check Passed The description clearly explains the new Mosaic Waitlist component, its behavior, tests, Swingset integration, and known limitations.
Title check Passed The title clearly identifies the main change: adding the Waitlist feature to Mosaic.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 9.09% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 11 functions across 18 files. (1 skipped: 1 unsupported.)

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

Finishing Touches: 💡 1
🛠️ Fix failing CI checks: 💡
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Linked repositories: Some configured repositories could not be included in this review. Cross-repository analysis may be incomplete. Please check linked-repository access and settings.

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@10501

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@10501

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@10501

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@10501

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@10501

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@10501

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@10501

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@10501

@clerk/expo-biometrics

npm i https://pkg.pr.new/@clerk/expo-biometrics@10501

@clerk/expo-google-signin

npm i https://pkg.pr.new/@clerk/expo-google-signin@10501

@clerk/expo-native-components

npm i https://pkg.pr.new/@clerk/expo-native-components@10501

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@10501

@clerk/express

npm i https://pkg.pr.new/@clerk/express@10501

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@10501

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@10501

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@10501

@clerk/mosaic

npm i https://pkg.pr.new/@clerk/mosaic@10501

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@10501

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@10501

@clerk/react

npm i https://pkg.pr.new/@clerk/react@10501

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@10501

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@10501

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@10501

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@10501

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@10501

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@10501

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@10501

commit: 469562f

This branch was successfully deployed

2 active deployments
Preview – swingset — 469562fd Deployed Oct 29, 2026 by vercel[bot]
Preview – clerk-js-sandbox — 469562fd Deployed Oct 28, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants